Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data layer functions #113

Merged
merged 4 commits into from
Feb 9, 2024
Merged

Data layer functions #113

merged 4 commits into from
Feb 9, 2024

Conversation

barnabasJ
Copy link
Contributor

@barnabasJ barnabasJ commented Feb 7, 2024

Allow DataLayer Filters (like, ilike from postgres in filter)

depends on

Very naive first implementation. It works in my project already, but I feel I'm probably missing some edge cases.
Somehow, the filter is already only applied to String attributes, but I'm not completely sure why.

@zachdaniel
Copy link
Contributor

AshGraphql is looking for functions that are type-compatible. In ilike and like it has a type signature f [[:string, :string]]

@zachdaniel
Copy link
Contributor

(Thats why it knows what types to support)

@zachdaniel
Copy link
Contributor

Okay, maybe not 😆 I’m not sure how it could only be supporting strings. I think the function variation will need to do something similar to what the operator code does. In fact, ideally they’d share the same code instead of branching.

@barnabasJ
Copy link
Contributor Author

AshGraphql is looking for functions that are type-compatible. In ilike and like it has a type signature f [[:string, :string]]

I may have looked at the wrong place.

@zachdaniel
Copy link
Contributor

Is this good to go?

@barnabasJ
Copy link
Contributor Author

Is this good to go?

Everything is fine from my side.

@zachdaniel zachdaniel merged commit c82512d into main Feb 9, 2024
13 checks passed
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants