improvement: return a map from decode_relay_id/1 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slight API improvement over ash-project#106. This makes it more ergonomic to partially match on the return value (and it also makes it more explicit by explicitly labeling the two parts). Also add tests for relay id encoding/decoding.
zachdaniel
approved these changes
Jan 25, 2024
|
🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight API improvement over #106.
This makes it more ergonomic to partially match on the return value (and it also makes it more explicit by explicitly labeling the two parts).
Also add tests for relay id encoding/decoding.
Contributor checklist