feat: add more sort order values (#91)

ash-project · Aug 28, 2023 · bce89e9 · bce89e9
1 parent da1d1e8
commit bce89e9
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/lib/api/api.ex b/lib/api/api.ex
@@ -196,12 +196,40 @@ defmodule AshGraphql.Api do
           name: "DESC",
           value: :desc
         },
+        %Absinthe.Blueprint.Schema.EnumValueDefinition{
+          module: schema,
+          identifier: :desc_nils_first,
+          __reference__: AshGraphql.Resource.ref(env),
+          name: "DESC_NULLS_FIRST",
+          value: :des_nils_first
+        },
+        %Absinthe.Blueprint.Schema.EnumValueDefinition{
+          module: schema,
+          identifier: :desc_nils_last,
+          __reference__: AshGraphql.Resource.ref(env),
+          name: "DESC_NULLS_LAST",
+          value: :desc_nils_last
+        },
         %Absinthe.Blueprint.Schema.EnumValueDefinition{
           module: schema,
           identifier: :asc,
           __reference__: AshGraphql.Resource.ref(env),
           name: "ASC",
           value: :asc
+        },
+        %Absinthe.Blueprint.Schema.EnumValueDefinition{
+          module: schema,
+          identifier: :asc_nils_first,
+          __reference__: AshGraphql.Resource.ref(env),
+          name: "ASC_NULLS_FIRST",
+          value: :asc_nils_first
+        },
+        %Absinthe.Blueprint.Schema.EnumValueDefinition{
+          module: schema,
+          identifier: :asc_nils_last,
+          __reference__: AshGraphql.Resource.ref(env),
+          name: "ASC_NULLS_LAST",
+          value: :asc_nils_last
         }
       ],
       identifier: :sort_order,

diff --git a/test/paginate_test.exs b/test/paginate_test.exs
@@ -33,7 +33,7 @@ defmodule AshGraphql.PaginateTest do
     test "default_limit records are fetched" do
       doc = """
       query KeysetPaginatedPosts {
-        keysetPaginatedPosts(sort: [{field: TEXT}]) {
+        keysetPaginatedPosts(sort: [{field: TEXT, order: ASC_NULLS_LAST}]) {
           count
           startKeyset
           endKeyset