Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for s3 api, Added events, Bootstrap3 progressbar, extra headers #15

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

dotansimha
Copy link

Changes:

  • Fixes for s3 API (changed the "key" to "AWSAccessKeyId")
  • Change progressbar template to work with Bootstrap 3
  • Added events for start upload, upload done, upload failed
  • Added ability to add custom headers for upload request.
  • Changed HTTPS to HTTP to support non-https sites

Usage example:

      $scope.s3UploadOptions =
      {
          getOptionsUri: s3ErasOptionsUri,
          folder: "",
          acl: "private",
          uploadStartCallback: function()
          {
          },
          uploadDoneCallback: function(fileUrl, fileKey)
          {
          },
          uploadErrorCallback: function()
          {
          }
      };

@asafdav
Copy link
Owner

asafdav commented Mar 29, 2014

Hi there,
few questions:

  1. Why did you change the url to http instead of https ? It shouldn't be a problem to access secured resources from an unsecured resource, but it doesn't work the other way around.
  2. Why did you change "key" name ? I'd rather leave it as is to keep backward compatibility
  3. I just merged another pull request that added custom events to the upload service, would you mind look at it and let me know if it suits your need ?

@dotansimha
Copy link
Author

Hi,

  1. actualy changed it because of some problems I have specific in my enviroment that related to the https... I can be reversed to https.
  2. I changed the key becuase the current API required that the name of the property will by AWSAccessKeyId... I dont think that backward compatibility is required as the "key" is not a valid property in S3 right now...
  3. It actually suits my needs and looks good.

@dotansimha
Copy link
Author

Also, accessing from HTTP to HTTPS might cause some errors related to Cross Origin.
I think it should be a configuration option..

@asafdav
Copy link
Owner

asafdav commented Apr 27, 2014

Hi Dotan,
Do you mind updating your code following our discussing here ?
I mean remove the code duplications and adjust to the latest version of s3Upload ?

I'll be more than happy to merge your pull request afterwards.

@asafdav
Copy link
Owner

asafdav commented Jul 17, 2014

Any progress ?

@jonahglover
Copy link

Were these issues ever resolved?

@asafdav
Copy link
Owner

asafdav commented Nov 11, 2014

Which issue ? we added a lot of features since then .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants