Adding onTap on ExpandablePanel
#93
Open
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update of this pull req? or this library is not in the maintenance anymore? |
|
This is a heavily desired feature. Can this PR move forward? |
|
@jlandau10 The solution I'm using now is to copy this repository to my personal repository (fork), then I make my own pull request that takes from this branch. |
maybe a bit better than having to re-edit the package file every time it gets cleaned, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's important to add callback parameter on
ExpandablePanelstate changed. i know that we can achieve this with listen toExpandableControlleras well, but it's a little bit complicated because we need to create, listen, and dispose controller. Please consider to merge this PR :)