Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shape finder when it's not provided #159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dcangulo
Copy link

I have a lot of the following code when it can be included internally instead:

direction, curve = find_shape(x, y)
kl = KneeLocator(x, y, curve=curve, direction=direction)

PS: this may be a breaking change on some projects since I'm changing the default values and they depend on the default concave and increasing without setting it explicitly and it don't match with what find_shape returns.

or we can keep concave and increasing as the default and just add another bool parameter like use_shape_finder, where if it's True then find_shape will be used so that it will not be breaking. Let me know what you think. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant