Use shape finder when it's not provided #159
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a lot of the following code when it can be included internally instead:
PS: this may be a breaking change on some projects since I'm changing the default values and they depend on the default
concave
andincreasing
without setting it explicitly and it don't match with whatfind_shape
returns.or we can keep
concave
andincreasing
as the default and just add anotherbool
parameter likeuse_shape_finder
, where if it'sTrue
thenfind_shape
will be used so that it will not be breaking. Let me know what you think. Thanks!