Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add from_dict #35

Merged
merged 9 commits into from
Nov 13, 2022
Merged

Add from_dict #35

merged 9 commits into from
Nov 13, 2022

Conversation

sethaxen
Copy link
Member

Implements a pure Julia from_dict to replace ArviZ's Python version. Currently it just dispatches to from_namedtuple after suitably converting it, but this can change later if InferenceData allows Dict storage, see #16.

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2022

Codecov Report

Merging #35 (102052e) into main (c060241) will decrease coverage by 0.18%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   96.12%   95.94%   -0.19%     
==========================================
  Files           8        9       +1     
  Lines         284      296      +12     
==========================================
+ Hits          273      284      +11     
- Misses         11       12       +1     
Impacted Files Coverage Δ
src/from_namedtuple.jl 95.12% <ø> (ø)
src/from_dict.jl 87.50% <87.50%> (ø)
src/utils.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sethaxen sethaxen merged commit 84a5aa8 into main Nov 13, 2022
@sethaxen sethaxen deleted the from_dict branch November 13, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants