-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make InferenceData and Dataset type-unstable #24
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 97.08% 97.75% +0.66%
==========================================
Files 10 9 -1
Lines 309 312 +3
==========================================
+ Hits 300 305 +5
+ Misses 9 7 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I'd like to in this PR also explore the feasibility of making |
Supporting mutable and type-unstable |
Fixes #15 by removing type annotations from
InferenceData
andDataset
. This makes high-order operations on these types compile quickly (and possibly automatically precompile), while operations on arrays are still compiled for the specific dimensions of that array and so are still fast.