Revert the commits for modifying the data index #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull-request addresses issue #5 Revisit index re-assignment when writing LAS file. It reverts commits related to index re-assignment.
The thinking for this pull-request is that it is better to accept dlisio's index curve and not make the assumption that another channel should be the index based on its name.
While the LAS 2.0 specification does indicate that the index curve should be named one of: 'DEPT', 'DEPTH', 'TIME', 'INDEX', many real world las files use a different name for the index.
A possible better solution is to give the users an option to rename the index curve. In that scenario the
rename
would need to be checked whether it already exists as the name of another curve. Consideration would need to be given to whether the rename should apply to all las files generated from a given Dlisio input or only specific ones.As an alternate solution users can use the Lasio tool to read las files with alternative index names. The index can be renamed within Lasio if the user needs to las files to specifically meet the the LAS 2.0 spec.
Reverted commits:
a20d419 Merge pull request #3 from
eecec92 Add test for new move_valid_index_to_first_col()
67dc925 Fix lascheck report of invalid data index channel
Tests:
All tests pass
Let me know if this change could be accepted (or rejected) or
needs some additional changes before being approved and merged.
Thank you,
DC