Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wild tab in service #153

Merged
merged 3 commits into from
Nov 7, 2024
Merged

fix wild tab in service #153

merged 3 commits into from
Nov 7, 2024

Conversation

greut
Copy link
Contributor

@greut greut commented Oct 23, 2024

A wild tab appeared in my code.

Signed-off-by: Yoan Blanc <[email protected]>
Copy link
Owner

@arttor arttor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution but it is not clear what problem is solved in this PR and why it should be merged. Please add this information in PR desription or create corresponding issue.

pkg/processor/service/service.go Show resolved Hide resolved
@greut
Copy link
Contributor Author

greut commented Oct 28, 2024

why it should be merged

That big redish tab space.

Screenshot 2024-10-28 at 10-32-24 ServiceMonitor needs an actual service by greut · Pull Request #34 · CHORUS-TRE_workbench-operator

@greut greut requested a review from arttor November 6, 2024 13:37
@arttor arttor merged commit 36da3d4 into arttor:main Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants