Add Namespace to the metadata of generated resources in the Helm Chart. #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @arttor , |
arttor
requested changes
May 7, 2024
There was a problem hiding this comment.
we need to support backward compatibility. existing charts generated by helmify should not be changed after upgrade to the latest version. please add a feature flag and disable it by default (see #141 as example). we can name it --keep-ns or --preserve-ns.
arttor
requested changes
May 17, 2024
arttor
requested changes
May 21, 2024
arttor
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the repo to include the namespace in the metadata of the helm chart generated.
This is to overcome the enhancement requested in this issue.
Tested by running the test mentioned in the readme documentation.