Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lambda node 14 image #64

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Add lambda node 14 image #64

merged 1 commit into from
Aug 11, 2021

Conversation

mgreystone
Copy link
Member

Adds articulate/articulate-node:14-lambda image.

Looks like lambci is more or less deprecated at this point lambci/docker-lambda#329. So i'm going with the newer official amazon base image.

This is working locally. I'm not too sure how to get it on dockerhub.

@mgreystone mgreystone requested review from tylerodonnell and a team August 10, 2021 19:13
@mgreystone mgreystone requested a review from a team as a code owner August 10, 2021 19:13
@mgreystone mgreystone removed the request for review from a team August 10, 2021 19:16
Copy link
Member

@tylerodonnell tylerodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I saw that lambci was no longer the suggested route when looking at this earlier. Love seeing the official AWS image now!

@tylerodonnell
Copy link
Member

I can get this in Dockerhub once this PR gets merged.

@mgreystone mgreystone merged commit 9f2ae73 into master Aug 11, 2021
@mgreystone mgreystone deleted the 14-lambda-take2 branch August 11, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants