Stop using quoted vars #299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow to keep using export without warnings, e.g. our
`archivematica.spec` is doing the following:
export $(cat /etc/sysconfig/archivematica-dashboard)
|
CC @uofmsean - is this the fix you were expecting? I haven't been able to reproduce the warning. |
|
In reference to #268, the problem is that /etc/sysconfig/archivematica-dashboard needs to be able to specify variables with spaces in them (such as ARCHIVEMATICA_DASHBOARD_EMAIL_SUBJECT_PREFIX) and should also allow for comment lines starting with #. Using "export $(cat /etc/sysconfig/archivematica-dashboard)" doesn't handle those cases cleanly whereas the file is correctly sourced by /usr/lib/systemd/system/archivematica-dashboard.service with the EnvironmentFile parameter. I would expect that whatever works for systemd should also work for install scripts. The same would apply to the other sysconfig files and systemd unit files. |
sevein
added
the
Status: in progress
qubot
removed
the
Status: in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow to keep using export without warnings, e.g. our
archivematica.specis doing the following:Is this the right thing to do or we have better options?
Connects to #268.
Related: 551fe3a.