Keep stack traces in withError
#3573
Closed
+77
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kover Report
|
kyay10
reviewed
Jan 26, 2025
| callsInPlace(transform, AT_MOST_ONCE) | ||
| } | ||
| // recover({ return block(this) }) { raise(transform(it)) } | ||
| val raise = DefaultRaise(false) |
There was a problem hiding this comment.
Doesn't this mean that innerException would always have no stack trace?
There was a problem hiding this comment.
Why would that be the case? As I understand the inner stack trace comes from the point where the RaiseCancellationException is first thrown.
There was a problem hiding this comment.
Well, the inner exception is always going to be a NoTrace because it's created by a DefaultRaise(false). Otherwise, we would be creating a stack trace every time, which would defeat our optimizations.
|
It was too good to be true... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #3351. The idea is to "inline" the definition of
withError, and within it carefully copy stack traces. Since the "inner exception" already contains the stack trace including anywithError, we just need to copy it, not change it in any way.