Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve map test coverage #2980

Merged
merged 23 commits into from
Mar 24, 2023
Merged

Improve map test coverage #2980

merged 23 commits into from
Mar 24, 2023

Conversation

abendt
Copy link
Contributor

@abendt abendt commented Mar 15, 2023

Context

See issue #2894

Changes

Edit: with awesome help from the kotest slack i implemented a specialized Arb (see the linked issue)

@abendt abendt marked this pull request as ready for review March 15, 2023 12:46
Copy link
Member

@serras serras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I've left a small comment, because I think that associate reads better than map + toMap most of the times.

@serras
Copy link
Member

serras commented Mar 24, 2023

@abendt I've decided to remove the tests that checked that map2 and map3 where correct, because they introduce some flakiness in the tests (you may always get a bad run in which the property isn't satisfied).

@serras serras merged commit cc95e40 into arrow-kt:main Mar 24, 2023
@abendt abendt deleted the map_test branch March 24, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants