DataTypes conversion for the orderBy tag. #23
Conversation
…ilable to resolve the issue.
… columns anymore. When we define global column names and this columns is not available on all tables (for example join tables), we log a warning but do not fail comparing the dataset.
…of a column. Needed to fix the Yaml thing too, but do not know if it works there.
…hich will be reported as Strings by Jackson as well. But they should be end up as - for example - data type TIMESTAMP. This detection is done by an additional regex pattern.
…mapped to the data types of the specific database. For this to happen, the DBUnitConfiguration is used to get the DataTypeFactory (database specific).
…mapped to the data types of the specific database. For this to happen, the DBUnitConfiguration is used to get the DataTypeFactory (database specific).
…]but another column has the correct datatype.
| } | ||
|
|
||
| @Test | ||
| public void withInteger() |
There was a problem hiding this comment.
Minor thing - let's follow current convention of test method naming , so something like should_convert_integer_to_dbunit_bigint.
Another thing is to leverage fest-assert assertions (as they are used across the whole project) in favor of built-in junit assertions.
|
If I remember correctly you have mentioned that some integration tests are failing now after the changes you introduced to JSON datasets. Is it still the case? If so would it be possible to fix and include improvements in this pull request? Thanks! |
|
Hi Bartosz Tests are running fine until some tests dump data to /home/bartosz ... The only implication is that YAML Datatype is UNKNOWN -hard coded. Regards Cyrill Am 03.12.2012 um 13:13 schrieb Bartosz Majsak [email protected]:
|
|
"/home/bartosz"... hmmm :) gonna look at it. Is there really something env. dependent in the tests? |
|
TestNG IT-Tests I guess Am 03.12.2012 um 13:35 schrieb Bartosz Majsak [email protected]:
|
|
Thanks, will take care of it. |
|
I will submit another patch for Oracle tonight. Regards Cyrill Am 03.12.2012 um 14:02 schrieb Bartosz Majsak [email protected]:
|
|
Hi Bartosz, I have just committed a fix for the oracle database datatype double/decimal. Regards, Cyrill Am 03.12.2012 um 14:02 schrieb Bartosz Majsak [email protected]:
|
Hi Bartosz
There you have the pull request. I have added a json data type to database data type converter to handle the problem of database agnostic datatypes. Therefore, I read the DataTypeFactory.
Currently some IT-Tests are failing because the JSON-Files are wrong. You should not use the double quotes for numbers. Otherwise they will be end up as VARCHAR:
"id": "2", -----> "id": 2,
I will place another pull request if I have additional changes.
Regards,
Cyrill