Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'plugin create an extra Resources folder inside Resources with an empty google-info.plist' #328

Merged
merged 1 commit into from
Jul 4, 2017

Conversation

wolfg1969
Copy link
Contributor

@wolfg1969 wolfg1969 changed the title Fix plugin create an extra Resources folder inside Resources with an empty google-info.plist #327 Fix 'plugin create an extra Resources folder inside Resources with an empty google-info.plist' Jun 23, 2017
@wolfg1969
Copy link
Contributor Author

#327

@soumak77
Copy link
Contributor

soumak77 commented Jul 4, 2017

@robertarnesson Can this get published with a new release? iOS builds for this plugin appear to have been broken as a result of the cordova fix.

@robertarnesson robertarnesson merged commit 2522d2a into arnesson:master Jul 4, 2017
@soumak77
Copy link
Contributor

soumak77 commented Jul 4, 2017

@robertarnesson thanks for merging this! Could you publish a patch release so I can try out the new build?

@robertarnesson
Copy link
Contributor

@soumak77 you can try it from master without a release. will release when all changes are confirmed working :)

@soumak77
Copy link
Contributor

soumak77 commented Jul 4, 2017

@robertarnesson wasn't sure how to do that at first, but I figured it out. Testing now.

I think 9eecdf9 might have fixed the iOS build but wasn't part of the latest release. With #328 integrated, you might be able to revert the other change.

@soumak77
Copy link
Contributor

soumak77 commented Jul 4, 2017

@robertarnesson without any changes the following error occurs:

Executing script found in plugin cordova-plugin-firebase for hook "after_prepare": plugins/cordova-plugin-firebase/scripts/after_prepare.js
Error: Invalid data, chunk must be a string or buffer, not object

I had to revert change 9eecdf9 to fix the issue

soumak77 added a commit to soumak77/cordova-plugin-firebase that referenced this pull request Jul 4, 2017
reverts a change that is no longer needed after merging arnesson#328
@soumak77 soumak77 mentioned this pull request Jul 4, 2017
@soumak77
Copy link
Contributor

soumak77 commented Jul 4, 2017

@robertarnesson taking into account the discussion from #295, it might be best to just revert this change and let 9eecdf9 fix the issue. 9eecdf9 wasn't part of the latest release so I didn't realize that changed fixed the build.

@robertarnesson
Copy link
Contributor

@soumak77 yeah I think you're right

@soumak77
Copy link
Contributor

@robertarnesson this change needs to be re-added after #364 was merged

@soumak77 soumak77 mentioned this pull request Aug 16, 2017
tshoposki pushed a commit to eidoo/cordova-plugin-firebase that referenced this pull request Apr 2, 2020
…d of implementing app delegate `application:openURL:options` to prevent conflicts with other plugins.

Resolves [arnesson#328](dpa99c#328).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants