-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'plugin create an extra Resources folder inside Resources with an empty google-info.plist' #328
Conversation
@robertarnesson Can this get published with a new release? iOS builds for this plugin appear to have been broken as a result of the cordova fix. |
@robertarnesson thanks for merging this! Could you publish a patch release so I can try out the new build? |
@soumak77 you can try it from master without a release. will release when all changes are confirmed working :) |
@robertarnesson wasn't sure how to do that at first, but I figured it out. Testing now. I think 9eecdf9 might have fixed the iOS build but wasn't part of the latest release. With #328 integrated, you might be able to revert the other change. |
@robertarnesson without any changes the following error occurs:
I had to revert change 9eecdf9 to fix the issue |
reverts a change that is no longer needed after merging arnesson#328
@robertarnesson taking into account the discussion from #295, it might be best to just revert this change and let 9eecdf9 fix the issue. 9eecdf9 wasn't part of the latest release so I didn't realize that changed fixed the build. |
@soumak77 yeah I think you're right |
@robertarnesson this change needs to be re-added after #364 was merged |
…d of implementing app delegate `application:openURL:options` to prevent conflicts with other plugins. Resolves [arnesson#328](dpa99c#328).
The cause is https://github.com/apache/cordova-ios/pull/310/files.