RK3588: edge: Bump kernel from v6.11 to v6.12-rc #7372

ColorfulRhino · 2024-10-14T11:20:52Z

Description

Kernel 6.12 brings several improvements for the Rockchip RK3588, so we can drop some patches as listed below.

Dropped patches (have been upstreamed)

SoC patches:

0026-RK3588-Add-VPU121-H.264-Decoder-Support
0029-arm64-dts-rockchip-rk3588-add-RGA2-node

HDMI patches:

0130-phy-phy-rockchip-samsung-hdptx-Enable-runtime-PM
0131-phy-phy-rockchip-samsung-hdptx-Add-clock-provider
0134-drm-bridge-synopsys-Add-initial-support-for-DW-HDMI-Controller

Board patches:

1051-arm64-dts-rockchip-nanopct6-lts-and-fixes-v6
rk3588-nanopc-cm3588-nas.dts (keep compatibility include)

Patches that needed adaption for 6.12

0001-general-add-overlay-support
0024-RK3588-Add-Crypto-Support (asm/unaligned.h moved to linux/unaligned.h)
0025-RK3588-Add-HW-RNG-Support (rename driver file to avoid conflict with new 6.12 driver)

Added patches

0140 to 0142: New v10 HDMI output patchset from https://lore.kernel.org/all/20241016-b4-rk3588-bridge-upstream-v10-0-87ef92a6d14e@collabora.com/
1051: NanoPC-T6 dts additions as per Board: NanoPC T6 & LTS - Bump uboot from 2024.07 to 2024.10 mainline #7393

To Do

~~Test current patched-in hardware RNG driver against the newly introduced one in 6.12 (only introduced for RK3568, but might also be good for RK3588?)~~
Rewrite kernel patches (after all patches like the RNG or HDMI stuff has been sorted out)

How Has This Been Tested?

Please edit this list if you have successfully tested 6.12 on your board :) Thanks!

Build success: ./compile.sh build BOARD=cm3588-nas BRANCH=edge BUILD_DESKTOP=no BUILD_MINIMAL=no KERNEL_CONFIGURE=no RELEASE=trixie
Board: CM3588-NAS: Boot success without any apparent issues
HDMI untested, please comment if you can confirm that HDMI still works

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

efectn · 2024-10-14T11:23:57Z

Thanks for the PR. I will check HDMI today. I also agree with you that we need to adjust rng patch. I think we can add it as -v2 driver

ColorfulRhino · 2024-10-14T11:45:31Z

Meta discussion about reviews and security

Unfortunately, all the kernel patches show up as newly created files. This is due to the fact that both current and edge kernel were on the same kernel version 6.11 and when current was switched to 6.11, there was only one patch folder left for both edge and current.
This makes reviewing changes harder. I have tried to make it easier for everyone to review by using atomic commits (e.g. doing one commit where patches are copied without any changes from 6.11) and documenting which patches were dropped and which were changed. Hope this helps at least somewhat :)

However, this is also a security risk. since in theory I could have buried some vulnerability or malware deep into one of the patches (let's be real, probably noone is going to go through all the patches when they're all shown as newly added files instead 😅). If the patch files were simply moved, GitHub would show any changes to the files, making it way more difficult for an attacker to hide something. (example: last RK3588 kernel bump PR)

Can we please agree on some standard procedure so changes are easier to follow in the future?

E.g. Move both edge and current to new versions in the same PR? Or rename the patch folders to include edge or current? (Still looking for an even better solution which can be in two different PRs, please let us know if you have anything in mind).

ColorfulRhino · 2024-10-14T12:26:59Z

Hardware RNG driver evaluation

Tests

`/dev/random` (software implementation)

CM3588-NAS:

cat /dev/random | rngtest -c 10000
rngtest 2.4
Copyright (c) 2004 by Henrique de Moraes Holschuh
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

rngtest: starting FIPS tests...
rngtest: bits received from input: 200000032
rngtest: FIPS 140-2 successes: 9996
rngtest: FIPS 140-2 failures: 4
rngtest: FIPS 140-2(2001-10-10) Monobit: 0
rngtest: FIPS 140-2(2001-10-10) Poker: 1
rngtest: FIPS 140-2(2001-10-10) Runs: 1
rngtest: FIPS 140-2(2001-10-10) Long run: 2
rngtest: FIPS 140-2(2001-10-10) Continuous run: 0
rngtest: input channel speed: (min=1.863; avg=13.957; max=18.626)Gibits/s
rngtest: FIPS tests speed: (min=41.374; avg=134.771; max=147.856)Mibits/s
rngtest: Program run time: 1432229 microseconds

`/dev/hwrng` with the patched-in `rockchip-rng-rk3588.c` driver from patch number 0025

CM3588-NAS:

cat /dev/hwrng | rngtest -c 10000
rngtest 2.4
Copyright (c) 2004 by Henrique de Moraes Holschuh
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

rngtest: starting FIPS tests...
rngtest: bits received from input: 200000032
rngtest: FIPS 140-2 successes: 9994
rngtest: FIPS 140-2 failures: 6
rngtest: FIPS 140-2(2001-10-10) Monobit: 1
rngtest: FIPS 140-2(2001-10-10) Poker: 2
rngtest: FIPS 140-2(2001-10-10) Runs: 2
rngtest: FIPS 140-2(2001-10-10) Long run: 1
rngtest: FIPS 140-2(2001-10-10) Continuous run: 0
rngtest: input channel speed: (min=444.923; avg=23600.774; max=19531250.000)Kibits/s
rngtest: FIPS tests speed: (min=45.521; avg=132.260; max=146.719)Mibits/s
rngtest: Program run time: 9771854 microseconds

`/dev/hwrng` with the `rockchip-rng.c` driver that was added to mainline 6.12 only for RK3566

(rng node has to be added to the rk3588-base.dtsi)
Not going to test myself due to prioritizing other issues.

Not able to be tested since RK3588 has a different RNG hardware than RK3568 (@efectn ).

Result comparison and discussion

/dev/hwrng seems slightly worse than /dev/random in entropy quality and much worse in performance.

Option 1) We just leave the driver as-is (but there really is not much use for it since /dev/random is better in performance)

Option 2) We remove the patched-in rockchip-rng-rk3588.c driver from patch number 0025 and wait for a better one from upstream.

What do you think?

rpardini · 2024-10-15T18:56:23Z

Unfortunately, all the kernel patches show up as newly created files

Indeed. I feel your pain. We've tried those bumps every other way by now, and there's always the case where this might happen. If you really, really want to keep the history you can try this - which fools git into thinking the copies are really renames -- but that might or not get flattened out/rebased when it's eventually merged into main.

efectn · 2024-10-17T17:46:18Z

Just checked HDMI on Opi5 and it doesn't seem to work. It seems like the HDMI bridge pathces have been removed during rebases. They need to be re-added from https://lore.kernel.org/all/20241016-b4-rk3588-bridge-upstream-v10-0-87ef92a6d14e@collabora.com/

ColorfulRhino · 2024-10-18T10:33:44Z

Unfortunately, all the kernel patches show up as newly created files

Indeed. I feel your pain. We've tried those bumps every other way by now, and there's always the case where this might happen. If you really, really want to keep the history you can try this - which fools git into thinking the copies are really renames -- but that might or not get flattened out/rebased when it's eventually merged into main.

Interesting, thanks! I'll have a look at it when I got time. Fooling Git is one thing, but if fooling GitHub is possible, that is to see 😄

ColorfulRhino · 2024-10-18T10:36:36Z

Just checked HDMI on Opi5 and it doesn't seem to work. It seems like the HDMI bridge pathces have been removed during rebases. They need to be re-added from https://lore.kernel.org/all/20241016-b4-rk3588-bridge-upstream-v10-0-87ef92a6d14e@collabora.com/

Thanks for testing! Good to see that there is a very new (2 days old) HDMI patch. I will try to switch to these new patches soon.

Edit: Done. Not tested, but compiles fine.

ColorfulRhino · 2024-10-18T12:44:50Z

Update: Added commits:

rk3588: edge: Add new v10 patch for basic HDMI out support
rk3588: edge: Enable new HDMI output driver in kernel config
rk3588: edge: Enable kernel config option CONFIG_NETKIT
rk3588: edge: Rewrite kernel patches against 6.12-rc3

efectn · 2024-10-18T13:06:18Z

Hardware RNG driver evaluation

Tests

/dev/random (software implementation)

CM3588-NAS:
cat /dev/random | rngtest -c 10000
rngtest 2.4
Copyright (c) 2004 by Henrique de Moraes Holschuh
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

rngtest: starting FIPS tests...
rngtest: bits received from input: 200000032
rngtest: FIPS 140-2 successes: 9996
rngtest: FIPS 140-2 failures: 4
rngtest: FIPS 140-2(2001-10-10) Monobit: 0
rngtest: FIPS 140-2(2001-10-10) Poker: 1
rngtest: FIPS 140-2(2001-10-10) Runs: 1
rngtest: FIPS 140-2(2001-10-10) Long run: 2
rngtest: FIPS 140-2(2001-10-10) Continuous run: 0
rngtest: input channel speed: (min=1.863; avg=13.957; max=18.626)Gibits/s
rngtest: FIPS tests speed: (min=41.374; avg=134.771; max=147.856)Mibits/s
rngtest: Program run time: 1432229 microseconds
/dev/hwrng with the patched-in rockchip-rng-rk3588.c driver from patch number 0025

CM3588-NAS:
cat /dev/hwrng | rngtest -c 10000
rngtest 2.4
Copyright (c) 2004 by Henrique de Moraes Holschuh
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

rngtest: starting FIPS tests...
rngtest: bits received from input: 200000032
rngtest: FIPS 140-2 successes: 9994
rngtest: FIPS 140-2 failures: 6
rngtest: FIPS 140-2(2001-10-10) Monobit: 1
rngtest: FIPS 140-2(2001-10-10) Poker: 2
rngtest: FIPS 140-2(2001-10-10) Runs: 2
rngtest: FIPS 140-2(2001-10-10) Long run: 1
rngtest: FIPS 140-2(2001-10-10) Continuous run: 0
rngtest: input channel speed: (min=444.923; avg=23600.774; max=19531250.000)Kibits/s
rngtest: FIPS tests speed: (min=45.521; avg=132.260; max=146.719)Mibits/s
rngtest: Program run time: 9771854 microseconds
/dev/hwrng with the rockchip-rng.c driver that was added to mainline 6.12 only for RK3566

(rng node has to be added to the rk3588-base.dtsi) Not going to test myself due to prioritizing other issues.

Result comparison and discussion

/dev/hwrng seems slightly worse than /dev/random in entropy quality and much worse in performance.

Option 1) We just leave the driver as-is (but there really is not much use for it since /dev/random is better in performance)

Option 2) We remove the patched-in rockchip-rng-rk3588.c driver from patch number 0025 and wait for a better one from upstream.

What do you think?

I don't think we can use upstream rng driver since RK3568 and RK3588 have different RNG IPs. perhaps we can add rk3588 as v1 driver just as how it has been done for vendor driver https://github.com/armbian/linux-rockchip/blob/693a5ea9432443eb4a58eee8a37f3b34501eb21b/drivers/char/hw_random/rockchip-rng.c#L447

ColorfulRhino · 2024-10-18T16:33:32Z

I don't think we can use upstream rng driver since RK3568 and RK3588 have different RNG IPs. perhaps we can add rk3588 as v1 driver just as how it has been done for vendor driver https://github.com/armbian/linux-rockchip/blob/693a5ea9432443eb4a58eee8a37f3b34501eb21b/drivers/char/hw_random/rockchip-rng.c#L447

Thanks for checking! The driver (patch 0025) has been patched in for at least 3 kernel versions now. But as shown above, using /dev/random is simply superior. Let's not patch-in any stuff that for sure will not be part of mainline 😅 I am of the opinion that less complexity is better as a whole, largely also for maintainability.

The evaluation was more meant to see if the currently used driver is very bad as in should not be used at all (like the driver for RK3566 as seen in one of the links sent in this topic).

Since afaik users have to actively choose to use /dev/hwrng for any given application instead of the usual /dev/random, I honestly doubt that more than a few people are using it (if even). Please correct me if I'm wrong :)

@sfx2000 also seems to be interested in RNG crypto stuff and has posted a nice comment about this topic a while back, see #6781 (comment)

efectn · 2024-10-18T18:33:47Z

Yeah i agree with you. Let's remove it for now

rpardini · 2024-10-20T11:53:58Z

Cherry picked, built ok. Tested on R6C, most stuff seems to work (HDMI untested).
There's a constant panic and hang on reboot related to rockchip_drm_platform_shutdown, though:

Details

[   78.224471] Unable to handle kernel NULL pointer dereference at virtual address 00000000000000a8
[   78.225245] Mem abort in: DABT (current EL), IL = 32 bits
[   78.226291]   SET = 0, FnVPTW = 0
  78.227289] Data abort info:level 0 translation fault
[   78.227546]   ISV = 0, ISS = 0, ISS2 = 0x00000000
[   78.228027]   CM = 0, WnR = 0, TnD = 0, ess = 0
[   78.228470]   GCS = 0, Overlay = 0, DirtyBit = 0, Xs0
[   78.228938] user pgtable: 4k pages, 48-bit VAs, pgdp=00000800000
[   78.229503] [00000000000000a8] pgd=0000000000000000, p4d=0000000000000000
[   78.230104] Internal error: Oops: 0000000096000004 [#1] PREEMPT SMP
[   78.230656] Modules linked in: tls cfg80211 rfkill sunrpc binfmt_misc hantro_vpu crct10dif_ce rockchip_vdec2 rockchip_rga v4l2_vp9 at24 v4l2_jpeg rk805_pwrkey v4l2_h264 v4l2_mem2mem videobuf2_dma_sg videobuf2_dma_contig videobuf2_memops rk_crypto2 videobuf2_v4l2 nvmem_rockchip_otp sm3_generic videodev crypto_engine rockchip_rng_rk3588 sm3 videobuf2_common mc ip_tables x_tables autofs4 dm_mod r8169 rk808_regulator phy_rockchip_samsung_hdptx rk8xx_spi rk8xx_core rockchipdrm dw_hdmi_qp dw_mipi_dsi dw_hdmi analogix_dp cec drm_dma_helper panthor drm_gpuvm gpu_sched drm_display_helper drm_shmem_helper drm_exec drm_kms_helper drm adc_keys
[   78.235652] CPU: 1 UID: 0 PID: 1 Comm: systemd-shutdow Not tainted 6.12.0-rc3-edge-rockchip-rk3588 #1
[   78.236459] Hardwre name: FriendlyElec NanoPi R6C (DT)
[   78.236919] pstate: 609 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[   78.237530]pc : drm_atomic_helper_shutdown+0x34/0x140 [drm_kms_helper]
[  78.238126] lr : rockchip_drm_platform_shutdown+0x18/0x28 [rockch
[   78.238734] sp : ffff80008005bba0
[   78.239028] x29: ffff80008005bba0 x28: ffff6872403ab480 x27: 0000000000000000
[   78.239661] x26: 0000000000000008 x25: ffffa9914783b848 x24: ffffa948918048
[   78.240293] x23: ffff687240bc5890 x22: ffffa991489cx21: ffffa99148805430
[   78.240925] x20: ffff687240fd4000 x19:ffff687240bc5818 x18: 0000000000000003
[   78.241558] x17: ffffb2c0 x16: 0000000000000000 x15: ffffa99147609118
[   78.242190]0000000000000b x13: ffff6872402bb210 x12: 0000000000000000
[   42822] x11: 0000000000000040 x10: ffffa99148630158 x9 : ffffa99148630150
[   78.243454] x8 : ffff6872404034a0 x7 : 0000000000000000 x6 : 0000000000000000
[   78.244086] x5 : ffff687240403478 x4 : ffff687240403510 x3 : 0000000000000000
[   78.244717] x2 : 0000000000000001 x1 : 0000000000000000 x0 : 0000000000000000
[   78.245349] Call trace:
[   78.245567]  drm_atomic_helper_shutdown+0x34/0x140 [drm_kms_helper]
[   78.246128]  rockchip_drm_platform_shutdown+0x18/0x28 [rockchipdrm]
[   78.246687]  platform_shutdown+0x24/0x34
[   78.247039]  device_shutdown+0x154/0x258
[   78.247389]  kernel_restart+0x40/0xa8
[   78.247718]  __do_sys_reboot+0x1e0/0x26c
[   78.248069]  __arm64_sys_reboot+0x24/0x30
[   78.248426]  invoke_syscall+0x48/0x110
[   78.248763]  el0_svc_common.constprop.0+0x40/0xe8
[   78.249181]  do_el0_svc+0x20/0x2c
[   78.249479]  el0_svc+0x38/0x100
[   78.249762]  el0t_64_sync_handler+0x13c/0x158
[   78.250149]  el0t_64_sync+0x1a4/0x1a8
[   78.250479] Code: b4000554 f90013f5 f9401a80 b9406a81 (b940a800)
[   78.251014] ---[ end trace 0000000000000000 ]---
[   78.251442] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
[   78.252185] Kernel Offset: 0x2990c6200000 from 0xffff800080000000
[   78.252720] PHYS_OFFSET: 0xffff978ec0000000
[   78.253089] CPU features: 0x1c,00000017,00280928,4200720b
[   78.253564] Memory Limit: none
[   78.253837] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ]---

Ref: https://lore.kernel.org/linux-rockchip/[email protected]/

Source: https://lore.kernel.org/all/20241016-b4-rk3588-bridge-upstream-v10-0-87ef92a6d14e@collabora.com/^ ----------------------------- **Quote from source:** Subject: [PATCH v10 0/3] Add initial support for the Rockchip RK3588 HDMI TX Controller Date: Wed, 16 Oct 2024 23:06:50 +0300 The Rockchip RK3588 SoC family integrates the Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX controller, which is a new IP block, quite different from those used in the previous generations of Rockchip SoCs. The controller supports the following features, among others: * Fixed Rate Link (FRL) * Display Stream Compression (DSC) * 4K@120Hz and 8K@60Hz video modes * Variable Refresh Rate (VRR) including Quick Media Switching (QMS) * Fast Vactive (FVA) * SCDC I2C DDC access * Multi-stream audio * Enhanced Audio Return Channel (EARC) This is the last component that needs to be supported in order to enable the HDMI output functionality on the RK3588 based SBCs, such as the RADXA Rock 5B. The other components are the Video Output Processor (VOP2) and the Samsung IP based HDMI/eDP TX Combo PHY, for which basic support has been already made available via [1] and [2], respectively. Please note this is a reworked version of the original series, which relied on a commonized dw-hdmi approach. Since the general consensus was to handle it as an entirely new IP, I dropped all patches related to the old dw-hdmi and Rockchip glue code - a few of them might still make sense as general improvements and will be submitted separately. It's worth mentioning the HDMI output support is currently limited to RGB output up to 4K@60Hz, without audio, CEC or any of the HDMI 2.1 specific features. Moreover, the VOP2 driver is not able to properly handle all display modes supported by the connected screens, e.g. it doesn't cope with non-integer refresh rates. A possible workaround consists of enabling the display controller to make use of the clock provided by the HDMI PHY PLL. This is still work in progress and will be submitted later, as well as the required DTS updates. To facilitate testing and experimentation, all HDMI output related patches, including those part of this series, are available at [3]. So far I could only verify this on the RADXA Rock 5B board. Thanks, Cristian [1]: 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588") [2]: 553be2830c5f ("phy: rockchip: Add Samsung HDMI/eDP Combo PHY driver") [3]: https://gitlab.collabora.com/hardware-enablement/rockchip-3588/linux/-/commits/rk3588-hdmi-bridge-v6.12-rc2 [4]: https://lore.kernel.org/lkml/[email protected]/ Signed-off-by: Cristian Ciocaltea <[email protected]>

`CONFIG_ROCKCHIP_DW_HDMI_QP`

Ported from `rk3588-current`, see #7385 8d41177

Source: https://lore.kernel.org/linux-rockchip/[email protected]/T/#m009c1b70ba8dc287084b3b08ff415fc391ebbde7

ColorfulRhino · 2024-10-20T19:11:32Z

Updates:

Removed patch 0025 (HW RNG driver) as discussed above
Added latest HDMI0 dts node patch

SuperKali · 2024-10-21T09:15:54Z

@ColorfulRhino good job, i had to test it with my latest PR #7393 because 6.11 usually have problem with this https://lore.kernel.org/all/CANa58ee6EeT9V7Q=epoZdqYw3sLh1CZGNWqJ0UcKMp6eRfcd+Q@mail.gmail.com/T/

Have you experienced this problem?

ColorfulRhino · 2024-10-21T10:01:11Z

Have you experienced this problem?

I have not experienced this issue so far, no.

SuperKali · 2024-10-21T10:08:27Z

@ColorfulRhino after merging this #7393 we've to align this PR

Co-authored-by: SuperKali <[email protected]>

ColorfulRhino · 2024-10-21T14:19:27Z

@ColorfulRhino after merging this #7393 we've to align this PR

Done, thanks to easy-to-port patch ;)

SuperKali · 2024-10-21T14:20:07Z

@ColorfulRhino after merging this #7393 we've to align this PR

Done, thanks to easy-to-port patch ;)

Awesome, i will test my part with nanopc t6 lts :)

ColorfulRhino · 2024-10-21T14:21:21Z

There's a constant panic and hang on reboot related to rockchip_drm_platform_shutdown, though:

@rpardini On CM3588 I could not replicate this issue (flash, first boot, configure, reboot, reboot again just fine). Maybe the commits that came after your tests did fix it or it is specific to NanoPi-R6C?

SuperKali · 2024-10-21T17:46:54Z

Tested myself on nanopc t6 its and works

SuperKali · 2024-10-21T17:55:39Z

uhm after install boot on SPI and the system on emmc I got this error panic:

[    4.247441] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000100
[    4.248129] CPU: 4 UID: 0 PID: 1 Comm: run-init Not tainted 6.12.0-rc4-edge-rockchip-rk3588 #1
[    4.248890] Hardware name: FriendlyElec NanoPC-T6 LTS (DT)
[    4.249374] Call trace:
[    4.249592]  dump_backtrace+0x94/0x114
[    4.249932]  show_stack+0x18/0x24
[    4.250228]  dump_stack_lvl+0xc8/0xf4
[    4.250558]  dump_stack+0x18/0x24
[    4.250854]  panic+0x3c0/0x3d4
[    4.251132]  do_exit+0x8a0/0x9c8
[    4.251420]  make_task_dead+0x0/0x188
[    4.251747]  invoke_syscall+0x48/0x110
[    4.252086]  el0_svc_common.constprop.0+0x40/0xe8
[    4.252508]  do_el0_svc+0x20/0x2c
[    4.252808]  el0_svc+0x38/0x100
[    4.253093]  el0t_64_sync_handler+0x13c/0x158
[    4.253483]  el0t_64_sync+0x1a4/0x1a8
[    4.253811] SMP: stopping secondary CPUs
[    4.254247] Kernel Offset: disabled
[    4.254556] CPU features: 0x1c,00000007,00280928,4200720b
[    4.255034] Memory Limit: none
[    4.255311] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000100 ]---

have you experienced this issue?

The-going · 2024-10-21T18:16:19Z

the system on emmc I got this error panic:

Is the file system on eMMC OK?

efectn · 2024-10-21T18:22:17Z

uhm after install boot on SPI and the system on emmc I got this error panic:

[    4.247441] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000100
[    4.248129] CPU: 4 UID: 0 PID: 1 Comm: run-init Not tainted 6.12.0-rc4-edge-rockchip-rk3588 #1
[    4.248890] Hardware name: FriendlyElec NanoPC-T6 LTS (DT)
[    4.249374] Call trace:
[    4.249592]  dump_backtrace+0x94/0x114
[    4.249932]  show_stack+0x18/0x24
[    4.250228]  dump_stack_lvl+0xc8/0xf4
[    4.250558]  dump_stack+0x18/0x24
[    4.250854]  panic+0x3c0/0x3d4
[    4.251132]  do_exit+0x8a0/0x9c8
[    4.251420]  make_task_dead+0x0/0x188
[    4.251747]  invoke_syscall+0x48/0x110
[    4.252086]  el0_svc_common.constprop.0+0x40/0xe8
[    4.252508]  do_el0_svc+0x20/0x2c
[    4.252808]  el0_svc+0x38/0x100
[    4.253093]  el0t_64_sync_handler+0x13c/0x158
[    4.253483]  el0t_64_sync+0x1a4/0x1a8
[    4.253811] SMP: stopping secondary CPUs
[    4.254247] Kernel Offset: disabled
[    4.254556] CPU features: 0x1c,00000007,00280928,4200720b
[    4.255034] Memory Limit: none
[    4.255311] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000100 ]---

have you experienced this issue?

I also sometimes get the same kernel panic at SD card

SuperKali · 2024-10-21T18:38:01Z

I also sometimes get the same kernel panic at SD card

I'm retrying to rebuild the OS, I'm flashing now the sdcard I will look again.

SuperKali · 2024-10-21T18:56:41Z

After rebuilding the OS and reflashed the image on emmc via dd command through the img it works, but this is not normal that some time kernel crashes

The-going · 2024-10-21T19:00:57Z

@SuperKali Please check the file system on the eMMC partition after booting from the SD card.

SuperKali · 2024-10-21T19:02:30Z

@SuperKali Please check the file system on the eMMC partition after booting from the SD card.

Usually I install all on emmc because it's more faster than sd card, but I clean every time the partition.

The-going · 2024-10-21T19:05:20Z

Usually I install all on emmc because it's more faster than sd card, but I clean every time the partition.

The file system may be disrupted due to the wear and tear of a certain number of memory cells.
You record using the dd command.
That may be the problem.

SuperKali · 2024-10-21T19:06:14Z

The file system may be disrupted due to the wear and tear of a certain number of memory cells.
You record using the dd command.
That may be the problem.

Using armbian-install directly not works :(

SuperKali · 2024-10-21T21:12:49Z

the system on emmc I got this error panic:

Is the file system on eMMC OK?

Obviously the emmc is ok, I’ve tried vendor kernel and works correctly 🙂

ColorfulRhino added Discussion Being discussed - Voice your opinions :) Needs review Seeking for review labels Oct 14, 2024

ColorfulRhino requested review from rpardini and efectn October 14, 2024 11:20

ColorfulRhino requested review from SuperKali, Tonymac32, amazingfate, lanefu, schwar3kat and igorpecovnik as code owners October 14, 2024 11:20

github-actions bot added size/large PR with 250 lines or more Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Oct 14, 2024

ColorfulRhino force-pushed the rk3588-6.12-initial branch from 02f2d78 to 4b68df2 Compare October 14, 2024 13:51

ColorfulRhino added the 11 Milestone: Fourth quarter release label Oct 14, 2024

igorpecovnik added the Work in progress Unfinished / work in progress label Oct 18, 2024

ColorfulRhino force-pushed the rk3588-6.12-initial branch from 4b68df2 to 7d927d4 Compare October 18, 2024 12:41

ColorfulRhino mentioned this pull request Oct 20, 2024

CM3588-NAS: Go fully mainline by adopting the latest mainline changes from kernel 6.11 and U-Boot v2024.10 #7082

Open

10 tasks

ColorfulRhino added 8 commits October 20, 2024 21:02

rk3588: edge: Enable newly added CONFIG_RTW89_8852BT

ad99f69

rk3588: edge: Enable newly added CONFIG_VIDEO_HANTRO_HEVC_RFC

f9b3aa0

Ref: https://lore.kernel.org/linux-rockchip/[email protected]/

board: cm3588-nas: Add HDMI support for edge kernel 6.12

2baccd6

rk3588: edge: Enable new HDMI output driver in kernel config

b4fefa3

`CONFIG_ROCKCHIP_DW_HDMI_QP`

rk3588: edge: Enable kernel config option CONFIG_NETKIT

c7f6f89

Ported from `rk3588-current`, see #7385 8d41177

rk3588: edge: Rewrite kernel patches against 6.12-rc3

d5ed3de

rk3588: edge: Update patch Add HDMI0 node to latest submitted

71aef28

Source: https://lore.kernel.org/linux-rockchip/[email protected]/T/#m009c1b70ba8dc287084b3b08ff415fc391ebbde7

ColorfulRhino force-pushed the rk3588-6.12-initial branch from 7d927d4 to 71aef28 Compare October 20, 2024 19:10

ColorfulRhino and others added 3 commits October 21, 2024 15:07

kernel: mainline: Bump v6.12-rc3 to v6.12-rc4

c868bc1

rk3588: edge: Rewrite kernel config against v6.12-rc4

496233e

board: nanopc-t6: Add USB3 power supply and pwm fan to DTS

696fb55

Co-authored-by: SuperKali <[email protected]>

RK3588: edge: Bump kernel from v6.11 to v6.12-rc #7372

Are you sure you want to change the base?

RK3588: edge: Bump kernel from v6.11 to v6.12-rc #7372

Conversation

ColorfulRhino commented Oct 14, 2024 • edited Loading

Description

Dropped patches (have been upstreamed)

Patches that needed adaption for 6.12

Added patches

To Do

How Has This Been Tested?

Checklist:

efectn commented Oct 14, 2024

ColorfulRhino commented Oct 14, 2024

Meta discussion about reviews and security

ColorfulRhino commented Oct 14, 2024 • edited Loading

Hardware RNG driver evaluation

Tests

/dev/random (software implementation)

/dev/hwrng with the patched-in rockchip-rng-rk3588.c driver from patch number 0025

/dev/hwrng with the rockchip-rng.c driver that was added to mainline 6.12 only for RK3566

Result comparison and discussion

rpardini commented Oct 15, 2024

efectn commented Oct 17, 2024 • edited Loading

ColorfulRhino commented Oct 18, 2024

ColorfulRhino commented Oct 18, 2024 • edited Loading

ColorfulRhino commented Oct 18, 2024

efectn commented Oct 18, 2024

Hardware RNG driver evaluation

Tests

/dev/random (software implementation)

/dev/hwrng with the patched-in rockchip-rng-rk3588.c driver from patch number 0025

/dev/hwrng with the rockchip-rng.c driver that was added to mainline 6.12 only for RK3566

Result comparison and discussion

ColorfulRhino commented Oct 18, 2024

efectn commented Oct 18, 2024

rpardini commented Oct 20, 2024

ColorfulRhino commented Oct 20, 2024

SuperKali commented Oct 21, 2024

ColorfulRhino commented Oct 21, 2024

SuperKali commented Oct 21, 2024

ColorfulRhino commented Oct 21, 2024

SuperKali commented Oct 21, 2024

ColorfulRhino commented Oct 21, 2024

SuperKali commented Oct 21, 2024

SuperKali commented Oct 21, 2024

The-going commented Oct 21, 2024

efectn commented Oct 21, 2024

SuperKali commented Oct 21, 2024

SuperKali commented Oct 21, 2024

The-going commented Oct 21, 2024

SuperKali commented Oct 21, 2024

The-going commented Oct 21, 2024

SuperKali commented Oct 21, 2024

SuperKali commented Oct 21, 2024

ColorfulRhino commented Oct 14, 2024 •

edited

Loading

ColorfulRhino commented Oct 14, 2024 •

edited

Loading

`/dev/random` (software implementation)

`/dev/hwrng` with the patched-in `rockchip-rng-rk3588.c` driver from patch number 0025

`/dev/hwrng` with the `rockchip-rng.c` driver that was added to mainline 6.12 only for RK3566

efectn commented Oct 17, 2024 •

edited

Loading

ColorfulRhino commented Oct 18, 2024 •

edited

Loading

`/dev/random` (software implementation)

`/dev/hwrng` with the patched-in `rockchip-rng-rk3588.c` driver from patch number 0025

`/dev/hwrng` with the `rockchip-rng.c` driver that was added to mainline 6.12 only for RK3566