Creating Tests for the function submitJobs #3438
Conversation
Signed-off-by: shivam <[email protected]>
internal/executor/job/submit.go
Outdated
| @@ -53,7 +53,7 @@ type FailedSubmissionDetails struct { | |||
|
|
|||
| func (submitService *SubmitService) SubmitJobs(jobsToSubmit []*SubmitJob) []*FailedSubmissionDetails { | |||
| return submitService.submitJobs(jobsToSubmit) | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Please remove this change - there shouldn't be extra whitespace at the end of lines. (I think running golangci-lint will warn about things like this, and using go fmt file_xxx.go will fix it for you.
There was a problem hiding this comment.
Thanks @richscott I will make these changes
internal/executor/job/submit.go
Outdated
| @@ -110,7 +110,7 @@ func (submitService *SubmitService) submitWorker(wg *sync.WaitGroup, jobsToSubmi | |||
| // submitPod submits a pod to k8s together with any services and ingresses bundled with the Armada job. | |||
| // This function may fail partly, i.e., it may successfully create a subset of the requested objects before failing. | |||
| // In case of failure, any already created objects are not cleaned up. | |||
| func (submitService *SubmitService) submitPod(job *SubmitJob) (*v1.Pod, error) { | |||
| func (submitService *SubmitService) submitPod(job *SubmitJob) (*v1.Pod, error) { //iska krna h | |||
There was a problem hiding this comment.
This looks like a leftover note or typo - please remove it.
There was a problem hiding this comment.
Oh I missed it to remove
internal/executor/job/submit_test.go
Outdated
| @@ -94,3 +94,30 @@ func newArbitraryError(message string) error { | |||
| func newArmadaErrCreateResource() error { | |||
| return &armadaerrors.ErrCreateResource{} | |||
| } | |||
|
|
|||
| func TestSubmitJobs(t *testing.T){ | |||
| submitService := &SubmitService{ | |||
There was a problem hiding this comment.
I think running go fmt on this file would collapse the two lines of the SubmitService reference into one, since there are no members declared in it.
Bharadwajshivam28
force-pushed
the
test_coverage_submit.go
branch
from
80e1187
to
42244b1
Compare
Signed-off-by: shivam <[email protected]>
Bharadwajshivam28
force-pushed
the
test_coverage_submit.go
branch
from
42244b1
to
cb1ca31
Compare
|
@Bharadwajshivam28 Can you rebase this branch from |
refs #3390
Hey @richscott I am creating Test for the function submitJobs