Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proof of Work #75

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add Proof of Work #75

wants to merge 12 commits into from

Conversation

tsunrise
Copy link
Member

@tsunrise tsunrise commented Oct 8, 2021

Description

Add Cryptographic hash function trait, and proof of work.

closes: #74

blocking: arkworks-rs/bcs#2 (currently is a private repo)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

src/pow/mod.rs Outdated Show resolved Hide resolved
src/pow/mod.rs Outdated
Comment on lines 14 to 18
/// - **Preimage Resistance**: For all adversary, given y = H(x) where x is
/// random, the probability to find z such that H(z) = y is negligible.
/// - **Collision Resistant**: It's computationally infeasible to find two
/// distinct inputs to lead to same output. This property is also satisfied by
/// CRH trait implementors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also require one-way-ness.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I remembered incorrectly, but isn't Preimage resistance => one-way-ness?

@tsunrise tsunrise marked this pull request as ready for review October 14, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Proof of Work
3 participants