-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to wasmer 4.3 #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimal circom 2
Wasmer 4.0
Reuse existing WASM instance
pin correct wasix version
Pratyush
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
This looks worse than it is, and most of the lines are coming from the
Cargo.lock
file. The main changes are:wasmer
dep from2.3
to4.3
1.74
WitnessCalculator::new_from_wasm
constructorThese changes only affect witness generation using the wasm solver.
Details
The public interface is the same as before. The
wasmer
upgrades necessitated boilerplate changes. The high level is that any wasm module function call now takes theStore
as it's first argument, so there are a lot of changes to thread that value everywhere. Also there's a slightly different way to read a wasm instance's memory which gets rid of thepattern that was used everywhere.
Additionally I added a constructor
WitnessCalculator::new_from_wasm
that allows you to pass in an existing wasm instance and reuse it for multiple calls to witness generation. This is particularly useful for folding schemes where you would otherwise waste a lot of resources creating and destroying wasm instances -- something I have already experienced.