Improve R1CS File Loading Speed with BufReader #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pratyush
approved these changes
Jul 6, 2024
|
Hi Bruno, Thank you for your PR. Could you please rebase to the latest main branch and then we can merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the speed of reading R1CS files by introducing
BufReader. Frequent reading ofu32data significantly slows down the reading of R1CS files, andBufReaderoptimizes this by buffering large blocks of data, reducing the number of direct read calls to the disk. This change reduced the reading time of a file with 5 million R1CS constraints from 28 seconds to 1.2 seconds, significantly boosting efficiency.