Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved core python library code under core/ module #89

Merged
merged 5 commits into from
Jul 17, 2023
Merged

Moved core python library code under core/ module #89

merged 5 commits into from
Jul 17, 2023

Conversation

chelma
Copy link
Collaborator

@chelma chelma commented Jul 17, 2023

Description

  • Moved files from the python package's root directory to a better home under the core/ module.
  • No changes to the logic; just file relocation.

Tasks

Testing

  • Ran the unit tests; they passed

License

I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@chelma chelma requested a review from awick July 17, 2023 14:37
awick
awick approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@awick awick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chelma chelma merged commit dfef816 into main Jul 17, 2023
@chelma chelma deleted the rfc-create-destroy-2 branch July 17, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awick awick awick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chelma @awick