Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed misleading section of the README #153

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Removed misleading section of the README #153

merged 1 commit into from
Jan 17, 2024

Conversation

chelma
Copy link
Collaborator

@chelma chelma commented Jan 17, 2024

Description

  • The CLI now performs the cdk-bootstrap for the user and it isn't possible for them to perform it themselves due to the special arguments that must be passed. Having a section of the README imply that the user can perform this action will just cause pain.

Tasks

Testing

  • Ran cluster-create in a new region without doing a cdk-bootstrap. The CLI performed the bootstrap for me once it realized it was needed.
2024-01-17 08:01:31 - Executing command: deploy MyCluster-CaptureBucket MyCluster-CaptureNodes MyCluster-CaptureVPC MyCluster-OSDomain MyCluster-ViewerNodes
2024-01-17 08:01:31 - NOTE: This operation can take a while.  You can 'tail -f' the logfile to track the status.
2024-01-17 08:03:16 - The AWS Account/Region does not appear to be CDK Bootstrapped, which is required for deployment.  Attempting to bootstrap now...
2024-01-17 08:03:16 - Executing command: bootstrap aws://XXXXXXXXXXXX/ap-southeast-2
2024-01-17 08:03:16 - NOTE: This operation can take a while.  You can 'tail -f' the logfile to track the status.
2024-01-17 08:04:46 - Bootstrap succeeded
2024-01-17 08:04:46 - Executing command: deploy MyCluster-CaptureBucket MyCluster-CaptureNodes MyCluster-CaptureVPC MyCluster-OSDomain MyCluster-ViewerNodes

License

I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

* The CLI now performs the cdk-bootstrap for the user and it isn't
  possible for them to perform it themselves due to the special
  arguments that must be passed.  Having a section of the README
  imply that the user can perform this action will just cause pain.

Signed-off-by: Chris Helma <[email protected]>
@chelma chelma added the bug Something isn't working label Jan 17, 2024
@chelma chelma requested a review from awick January 17, 2024 16:29
@chelma
Copy link
Collaborator Author

chelma commented Jan 17, 2024

CI tests failing due to changes made to enable #152 to pass its tests. Safe to disregard.

@chelma chelma merged commit a1aec22 into main Jan 17, 2024
4 of 5 checks passed
@chelma chelma deleted the README-update branch January 17, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants