Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing to updated service Command NetworkManager #318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jatinkartik
Copy link

when I am disabling monitor mode using lscript its disables monitor mode but doesn't start network service I have to manually start it. then I have tested this script on multiple systems. but the result is the same.
After changing network-manager to NetworkManager. Now it's working fine.
network-manager is the symbolic link of NetworkManager. but it's not working on some virtual machine.
so take a look at my contribution. if you found this helpful merge it.
currently, I am testing this script if I found any issues. I will update it

@avidzcheetah
Copy link

This contribution resolves a critical compatibility issue by replacing network-manager with NetworkManager, ensuring the script works seamlessly across environments, including virtual machines. The fix has been tested on multiple systems and significantly improves reliability. I recommend merging this update.

Copy link

@avidzcheetah avidzcheetah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code diff shows a minor change in a script where the service network-manager has been replaced with NetworkManager. Here is a summary and review of the change:

Summary

The change updates the command to start the network manager service:

  • Old Command: service network-manager start
  • New Command: service NetworkManager start

Review

  1. Correct Naming: The change corrects the service name from network-manager to NetworkManager. This is likely because the correct service name is NetworkManager, which is case-sensitive.
  2. Functionality: This update ensures that the script correctly starts the NetworkManager service, which is crucial for network management tasks on systems using NetworkManager.
  3. Error Handling: The existing error handling and success messages are preserved, ensuring that any issues starting the service will still be reported properly.

Overall, this is a necessary and correct change to ensure the script functions as intended on systems where the service name is case-sensitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants