Add an additional option for closedPos. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closedPos: "absolute",// String: Position of the closed nav. Works the same as openPos, prevents from needing to use !important in CSS or modify the JS library if you want to set an alternative default position. Also, to get the positions entirely from CSS, both options can be set to "". I didn't make this the default to ensure backwards compatibility with existing sites. I've also updated readme.md to include the new option. I've been working with responsive-nav in a project and need to modify it to make it flexible enough to fit my needs. Hoping to push the changes back into the project for everyone else's benefit. Signed-off-by: Jonathan Haslett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closedPos: "absolute",// String: Position of the closed nav.
Works the same as openPos, prevents from needing to use !important in CSS or modify the JS library if you want to set an alternative default position.
Also, to get the positions entirely from CSS, both options can be set to "". I didn't make this the default to ensure backwards compatibility with existing sites.
I've also updated readme.md to include the new option.
I've been working with responsive-nav in a project and need to modify it to make it flexible enough to fit my needs. Hoping to push the changes back into the project for everyone else's benefit.
Signed-off-by: Jonathan Haslett [email protected]