Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I've made a small-ish update to add support for using an inline SVG as a
customToggle
. This fixes a javascript error I've encountered when I tried this for a site I'm working on. I'm putting this PR up in case it might be worth applying, but obviously feel free to ignore it if it doesn't fit.The error I encountered is...
The documentation on MDN regarding
className
mentions that if the element is an SVG thenclassName
returns an instance of SVGAnimatedString, rather than a string, which causes the error.I've updated responsive-nav.js to use
getAttribute
to determine the class name, as well as usingsetAttribute
to set the new class name, as recommended on MDN.