fix(ui): Show error message when max pods to view logs are reached #21725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
pjiang-dev
changed the title
pjiang-dev
changed the title
pjiang-dev
force-pushed
the
pjiang-dev/fix-logs-maxpod
branch
2 times, most recently
from
17ee38e to
1f0dd19
Compare
Signed-off-by: Peter Jiang <[email protected]>
pjiang-dev
force-pushed
the
pjiang-dev/fix-logs-maxpod
branch
from
1f0dd19 to
d7272b6
Compare
crenshaw-dev
reviewed
Feb 3, 2025
Comment on lines
+73
to
+80
| // If there is an error, show it beforehand | ||
| fetch(fullUrl).then(response => { | ||
| if (!response.ok) { | ||
| return response.text().then(text => { | ||
| observer.error({status: response.status, statusText: response.statusText, body: text}); | ||
| }); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Is the preflight request necessary? Wouldn't the onerror handler take care of this anyway?
There was a problem hiding this comment.
@crenshaw-dev The preflight request is needed because the onerror handler does not handle the HTTP request error (400 Bad Request) and swallows the error message.
Instead EventSource considers it a connection problem and throws the generic error('connection got closed unexpectedly')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21706
Displays an error message in the logs when error message on "max pods to view logs are reached" when there are more than 10 pods for a deployment/replica set for better user experience.
Before:
After:
Checklist: