chore: updates to Numaplane health checks

[juliev0]

Recently, we introduced "progressive" rollout strategy for Numaplane. This caused a new case for "Degraded". I ended up doing some refactoring through use of lua functions as part of this.

In addition to the unit tests, I did a considerable amount of verification on my local machine with an ArgoCD Application and Numaplane, testing the following cases as far as their health status in ArgoCD:

• Create one of each of all 4 Rollouts
• For each Rollout, perform pause and drain strategy update for a good rollout as well as a failing one
• For each Rollout, perform progressive update for a good rollout as well as a failing one

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@544aea1). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master   #21671   +/-   ##
=========================================
  Coverage          ?   55.40%           
=========================================
  Files             ?      339           
  Lines             ?    57182           
  Branches          ?        0           
=========================================
  Hits              ?    31681           
  Misses            ?    22826           
  Partials          ?     2675           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[crenshaw-dev]

@juliev0 does this need to be cherry-picked back to previous Argo CD versions, or is it fine to wait for 3.0?

[juliev0]

@juliev0 does this need to be cherry-picked back to previous Argo CD versions, or is it fine to wait for 3.0?

Hey @crenshaw-dev. So, this is only run within Intuit at the moment. So, I don't think it needs to be cherry picked or anything. All that matters, as far as we're concerned, is that we have the latest and greatest version running within Intuit.