Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: endorse secrets operators, caution against plugins (#21629) #21631

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

crenshaw-dev
Copy link
Member

@crenshaw-dev crenshaw-dev commented Jan 22, 2025

Closes #21629

@crenshaw-dev crenshaw-dev requested review from a team as code owners January 22, 2025 16:59
Copy link

bunnyshell bot commented Jan 22, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@crenshaw-dev crenshaw-dev marked this pull request as draft January 22, 2025 16:59
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is solid as is. I suggested maybe adding the secret csi driver. We could potentially work in this talk about different approaches to managing secrets https://www.youtube.com/watch?v=FVaaqP7_AJg&t=1s - but it doesn't directly address the issues with hydration secrets management so I don't mind skipping. I actually think we need an updated talk on this.

docs/operator-manual/secret-management.md Outdated Show resolved Hide resolved
Signed-off-by: Michael Crenshaw <[email protected]>
@leoluz leoluz self-requested a review January 23, 2025 16:59
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tks for the doc. My comments are non blockers but suggestions.

docs/operator-manual/secret-management.md Outdated Show resolved Hide resolved
docs/operator-manual/secret-management.md Outdated Show resolved Hide resolved
Signed-off-by: Michael Crenshaw <[email protected]>
@crenshaw-dev crenshaw-dev marked this pull request as ready for review January 29, 2025 19:44
@crenshaw-dev crenshaw-dev merged commit c32afb4 into argoproj:master Feb 3, 2025
23 checks passed
@crenshaw-dev crenshaw-dev deleted the secrets-opinion branch February 3, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have an opinion on Secrets
5 participants