Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add link to get the list of applications of a cluster/project #21561

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Add link to get the list of applications of a cluster/project #21561

wants to merge 2 commits into from
+40 −5

Conversation

almoelda
Copy link
Contributor

@almoelda almoelda commented Jan 19, 2025 •
edited
Loading

Closes #21454

  • Adding a util function for cluster query parameter since this will introduce 1 function which is used by several components
  • Applications link in cluster summary page
  • Applications link in project summary page

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@almoelda almoelda requested a review from a team as a code owner January 19, 2025 14:15
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jan 19, 2025 •
edited
Loading

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

@almoelda almoelda force-pushed the applications-link-in-settings branch from 2f911b5 to e35b614 Compare January 19, 2025 14:19
@almoelda
Adding a util function for cluster param, applications link in cluste…
a6bda35 
…r summary page and applications link in project summary page

Signed-off-by: Almo Elda <[email protected]>
@almoelda
eslint fixes
6e801c5 
Signed-off-by: Almo Elda <[email protected]>
@almoelda almoelda force-pushed the applications-link-in-settings branch from 968b057 to 6e801c5 Compare January 19, 2025 14:34
@almoelda almoelda mentioned this pull request Jan 19, 2025
Open
reggie-k
reggie-k reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@reggie-k reggie-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Could you attach a screenshot?

@almoelda
Copy link
Contributor Author

almoelda commented Jan 20, 2025 •
edited
Loading

Thanks for the PR! Could you attach a screenshot?

Sure. @reggie-k
I have tested locally applications for different projects and clusters

Screenshot 2025-01-20 at 10 45 25 Screenshot 2025-01-20 at 10 45 11

reggie-k
reggie-k reviewed Jan 20, 2025
View reviewed changes
ui/src/app/settings/components/cluster-details/cluster-details.tsx
Comment on lines +98 to +99
apps.items.filter(app => app.spec.destination.name === cluster.name || app.spec.destination.server === cluster.server)
.length
Copy link
Member

@reggie-k reggie-k Jan 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks great in the UI!
Why do we have to filter the results here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct me if I am wrong, I believe that the query options does not provide any way to filter by cluster, by taking a look at this https://github.com/argoproj/argo-cd/blob/master/pkg/apiclient/application/application.pb.go#L44-L64 I learned from this file which is filtering apps with the filter function as well https://github.com/argoproj/argo-cd/blob/master/ui/src/app/applications/components/application-details/application-details-app-dropdown.tsx#L38-L43

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I wonder whether we can filter inside list in ApplicationService instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean altering the QueryOptions or adding another callback to filter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reggie-k reggie-k reggie-k left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add link to get the list of applications of a cluster/project
2 participants
@almoelda @reggie-k