-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for azure workload identity in Microsoft Entra SSO. #21433
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
4827fcb
to
fdc0498
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21433 +/- ##
==========================================
- Coverage 55.41% 53.29% -2.13%
==========================================
Files 339 339
Lines 57200 57290 +90
==========================================
- Hits 31700 30532 -1168
- Misses 22829 24117 +1288
+ Partials 2671 2641 -30 ☔ View full report in Codecov by Sentry. |
55c3d23
to
9fc41b0
Compare
8814504
to
3bf9530
Compare
5679a70
to
7ee2f58
Compare
Signed-off-by: Jagpreet Singh Tamber <[email protected]> use client assertion in the idtoken generation. Signed-off-by: Jagpreet Singh Tamber <[email protected]> Use Kubernetes Service Account Token for assertion. Signed-off-by: Jagpreet Singh Tamber <[email protected]>
Signed-off-by: Jagpreet Singh Tamber <[email protected]>
Signed-off-by: Jagpreet Singh Tamber <[email protected]>
b47cab0
to
0e6d407
Compare
Rebased as the code coverage report was incorrect. |
Signed-off-by: Jagpreet Singh Tamber <[email protected]>
c34f384
to
8e40033
Compare
Signed-off-by: Jagpreet Singh Tamber <[email protected]>
Signed-off-by: Jagpreet Singh Tamber <[email protected]>
…load identity mutation webhook. Signed-off-by: Jagpreet Singh Tamber <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a small refactor to extract getAzureKubernetesFederatedServiceAccountToken
to the new struct and updated the unit tests to use a token in a temp test directory.
Enables the use of workload identity in configuring Microsoft Entra SSO, removes the secret management overhead for the AAD Apps. CLOSES #17595
Checklist: