Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for azure workload identity in Microsoft Entra SSO. #21433

Merged
merged 13 commits into from
Jan 29, 2025

Conversation

jagpreetstamber
Copy link
Contributor

@jagpreetstamber jagpreetstamber commented Jan 9, 2025

Enables the use of workload identity in configuring Microsoft Entra SSO, removes the secret management overhead for the AAD Apps. CLOSES #17595

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes. Support Azure Workload Identity for Microsoft Entra SSO #17595
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@jagpreetstamber jagpreetstamber requested review from a team as code owners January 9, 2025 14:02
Copy link

bunnyshell bot commented Jan 9, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@jagpreetstamber jagpreetstamber force-pushed the feat/sso-wi branch 4 times, most recently from 4827fcb to fdc0498 Compare January 10, 2025 13:55
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 87.12871% with 13 lines in your changes missing coverage. Please review.

Project coverage is 53.29%. Comparing base (1698370) to head (1dd1e65).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
util/oidc/oidc.go 86.53% 5 Missing and 2 partials ⚠️
util/test/testutil.go 86.04% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21433      +/-   ##
==========================================
- Coverage   55.41%   53.29%   -2.13%     
==========================================
  Files         339      339              
  Lines       57200    57290      +90     
==========================================
- Hits        31700    30532    -1168     
- Misses      22829    24117    +1288     
+ Partials     2671     2641      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jagpreetstamber jagpreetstamber force-pushed the feat/sso-wi branch 10 times, most recently from 55c3d23 to 9fc41b0 Compare January 17, 2025 17:36
docs/operator-manual/user-management/microsoft.md Outdated Show resolved Hide resolved
util/settings/settings.go Outdated Show resolved Hide resolved
util/test/testutil.go Outdated Show resolved Hide resolved
util/test/testutil.go Outdated Show resolved Hide resolved
util/oidc/oidc.go Outdated Show resolved Hide resolved
util/oidc/oidc.go Show resolved Hide resolved
Signed-off-by: Jagpreet Singh Tamber <[email protected]>

use client assertion in the idtoken generation.

Signed-off-by: Jagpreet Singh Tamber <[email protected]>

Use Kubernetes Service Account Token for assertion.

Signed-off-by: Jagpreet Singh Tamber <[email protected]>
Signed-off-by: Jagpreet Singh Tamber <[email protected]>
@jagpreetstamber
Copy link
Contributor Author

Rebased as the code coverage report was incorrect.

util/oidc/oidc_test.go Show resolved Hide resolved
util/oidc/oidc_test.go Show resolved Hide resolved
util/oidc/oidc.go Outdated Show resolved Hide resolved
util/oidc/oidc.go Outdated Show resolved Hide resolved
Signed-off-by: Jagpreet Singh Tamber <[email protected]>
Copy link
Member

@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a small refactor to extract getAzureKubernetesFederatedServiceAccountToken to the new struct and updated the unit tests to use a token in a temp test directory.

@agaudreault agaudreault enabled auto-merge (squash) January 28, 2025 23:29
@agaudreault agaudreault merged commit ecb9dba into argoproj:master Jan 29, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Azure Workload Identity for Microsoft Entra SSO
3 participants