Refresh examples and cleanup make targets #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotgunton
added
semver:patch
elliotgunton
force-pushed
the
refresh-examples
branch
from
b7b93ca to
feb557a
Compare
Signed-off-by: Elliot Gunton <[email protected]>
* Separate out test-lint target for faster local testing * Add test target for regenerate-test-data Signed-off-by: Elliot Gunton <[email protected]>
Signed-off-by: Elliot Gunton <[email protected]>
Signed-off-by: Elliot Gunton <[email protected]>
elliotgunton
force-pushed
the
refresh-examples
branch
from
feb557a to
c5bbaf1
Compare
alicederyn
approved these changes
Sep 30, 2024
Makefile
Outdated
| @@ -19,7 +19,7 @@ install-3.9: ## Install and use Python 3.9 for generating test data | |||
| .PHONY: ci | |||
| ci: ## Run all the CI checks | |||
| ci: CI=1 | |||
| ci: lint test check-codegen | |||
| ci: lint test test-lint check-codegen | |||
There was a problem hiding this comment.
Nice. Maybe test-annotations though? Or test-type-hints?
sambhav
approved these changes
Sep 30, 2024
Signed-off-by: Elliot Gunton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
make testDescription of PR
New examples were added for Argo Workflows 3.6, but we don't yet support the fields (until 3.6 official release, then #1215 will address this) - for now rename the
synchronizationexamples (addlegacysuffix).This PR also tidies up the
maketargets to avoid running unrelated code (regenerate-test-data) and separate out lint checks from the maintesttarget for faster iteration speed (addedtest-linttoci).