Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hera is not yet compatible with Argo Workflows 3.6 changes #1215

Open
5 tasks done
elliotgunton opened this issue Sep 30, 2024 · 2 comments · May be fixed by #1293
Open
5 tasks done

Hera is not yet compatible with Argo Workflows 3.6 changes #1215

elliotgunton opened this issue Sep 30, 2024 · 2 comments · May be fixed by #1293
Assignees
Labels
type:dependency-upgrade A dependency upgrade type:informational Provides information or notice to the community

Comments

@elliotgunton
Copy link
Collaborator

elliotgunton commented Sep 30, 2024

When 3.6 releases there will be new fields for some classes, and various new examples. This issue is to update the codebase once the official 3.6 release is made (currently rc1).

@elliotgunton elliotgunton added the type:dependency-upgrade A dependency upgrade label Sep 30, 2024
elliotgunton added a commit that referenced this issue Sep 30, 2024
**Pull Request Checklist**
- [x] Fixes `make test`
- [x] Tests added
- [x] Documentation/examples added
- [x] [Good commit messages](https://cbea.ms/git-commit/) and/or PR
title

**Description of PR**
New examples were added for Argo Workflows 3.6, but we don't yet support
the fields (until 3.6 official release, then #1215 will address this) -
for now rename the `synchronization` examples (add `legacy` suffix).

This PR also tidies up the `make` targets to avoid running unrelated
code (`regenerate-test-data`) and separate out lint checks from the main
`test` target for faster iteration speed (added `test-lint` to `ci`).

---------

Signed-off-by: Elliot Gunton <[email protected]>
@elliotgunton elliotgunton self-assigned this Dec 11, 2024
@mvorobie
Copy link

Hey @elliotgunton ,

There's another change in 3.6 that I am looking forward to, but I don't see listed here:
CronWorkflows StopStrategy

I hope this functionality will be included in Hera as well. Unfortunately I don't have time to contribute it myself.
Just wanted to highlight it in case it was missed.

@elliotgunton
Copy link
Collaborator Author

elliotgunton commented Dec 16, 2024

@mvorobie thanks for the heads up! Tomorrow I'll double check all the new features added in 3.6 - my PRs (#1293 / #1294) are mostly ready so it should be an easy add (I already added schedules and when for CronWorkflows) 🚀

@elliotgunton elliotgunton changed the title Argo Workflows 3.6 release changes Hera is not yet compatible with Argo Workflows 3.6 changes Jan 9, 2025
@elliotgunton elliotgunton pinned this issue Jan 9, 2025
@elliotgunton elliotgunton added the type:informational Provides information or notice to the community label Jan 9, 2025
elliotgunton added a commit that referenced this issue Jan 10, 2025
Manual changes required for #1215

---------

Signed-off-by: Elliot Gunton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:dependency-upgrade A dependency upgrade type:informational Provides information or notice to the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants