Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move pkg/health out of registry-scanner #995

Conversation

ishitasequeira
Copy link
Collaborator

Based on discussion in #972 (comment), moving the package pkg/health out of registry-scanner.

Also, add step for publishing code coverage of registry-scanner to codecov.io

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.07%. Comparing base (d07cf71) to head (371a96f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #995      +/-   ##
==========================================
+ Coverage   71.99%   72.07%   +0.08%     
==========================================
  Files          24       25       +1     
  Lines        3642     3653      +11     
==========================================
+ Hits         2622     2633      +11     
  Misses        880      880              
  Partials      140      140              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishitasequeira ishitasequeira marked this pull request as ready for review January 6, 2025 12:21
@chengfang chengfang merged commit 5ae9a45 into argoproj-labs:master Jan 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants