-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define inputs and outputs of steps/tasks as attributes instead of properties to simplify definition #1027
Open
plaguss
wants to merge
26
commits into
develop
Choose a base branch
from
input-output-classmethod
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to input-output-classmethod
Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-1027/ |
CodSpeed Performance ReportMerging #1027 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does a refactor of inputs/outputs properties of the steps to be defined in terms of attributes.
Defining a custom
Step
(orTask
) now needs to create the inputs and outputs as attributes instead of properties.Some classes need running some code, so making a general classmethod is not feasible (maybe I'm wrong?), for example the steps in the
columns.py
format need information from other attributes, or the loader classes need to fetch info from the datasets which only happen after calling.load()
.Instead of simplifying the access to these variables, it just simplifies the definition by writing less lines.
model_post_init
):Closes #836