Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

feat: migrate POST /api/workspaces endpoint to POST /api/v1/workspaces #150

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented May 7, 2024

Description

This PR adds a new endpoint POST /api/v1/workspace allowing the creation of new workspaces for API v1.

Changes of the new endpoint compared to the old one:

  • The new endpoint returns a 201 status code instead of the 200 returned by the old endpoint.

I have added also some changes to the new token creation endpoint to return 201 instead of 200.

Closes #149

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

  • Adding new tests and manually checking the old ones pass with the new endpoint.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo requested a review from frascuchon May 7, 2024 16:25
@jfcalvo jfcalvo linked an issue May 7, 2024 that may be closed by this pull request
Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder.

@jfcalvo jfcalvo requested a review from frascuchon May 10, 2024 16:01
@jfcalvo jfcalvo merged commit a74b377 into feat/move-api-v0-functionality-to-v1 May 13, 2024
10 checks passed
@jfcalvo jfcalvo deleted the feat/migrate-create-workspace-to-api-v1 branch May 13, 2024 10:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Migrate POST /api/workspaces endpoin to POST /api/v1/workspaces
2 participants