Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Allow import argilla_server module with pydantic 2.0 #12

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

frascuchon
Copy link
Member

Description

This PR allows the import of argilla_server modules when the Pydantic v2 package is installed. You can find the related work in the argilla repository

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • New feature (non-breaking change which adds functionality)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test A
  • Test B

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon changed the title Allow import argilla_server module with pydantic 2.0 Allow import argilla_server module with pydantic 2.0 Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b78613c) 90.13% compared to head (5ba4e11) 90.11%.

Files Patch % Lines
src/argilla_server/pydantic_v1/__init__.py 60.00% 2 Missing ⚠️
src/argilla_server/__init__.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   90.13%   90.11%   -0.03%     
==========================================
  Files         187      187              
  Lines        9178     9187       +9     
==========================================
+ Hits         8273     8279       +6     
- Misses        905      908       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon frascuchon merged commit ec79728 into main Feb 5, 2024
11 of 13 checks passed
@frascuchon frascuchon deleted the feat/use-argilla-server-as-python-package branch February 5, 2024 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants