feat: add webwallet connect and sign method #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluecco
changed the title
Cussone
reviewed
Feb 5, 2025
package.json
Outdated
| @@ -65,6 +65,7 @@ | |||
| "dev": "vite build --watch" | |||
| }, | |||
| "dependencies": { | |||
| "webwallet-sdk": "../webwallet-sdk", | |||
There was a problem hiding this comment.
To avoid having circular dependencies between webwallet-sdk and starknetkit, I would move ApprovalRequest type to starknetkit, and if needed reexport it from webwallet-sdk for the end user.
src/connectors/webwallet/index.ts
Outdated
| approvalRequests: ApprovalRequest[] | ||
| sessionTypedData: TypedData | ||
| }) /* | ||
| Promise<{ |
Cussone
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue / feature description
Quick description of the issue or the feature that is implemented in the pr ie: add new transitions between screensChanges
quick list regarding the related changes within the prie:
Checklist
Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.
Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.