fix: memory leak when scanning sketchbooks with large files #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomocusinato
force-pushed
the
#2537
branch
from
7f82f37
to
3486d93
Compare
giacomocusinato
changed the title
node-glob library
giacomocusinato
force-pushed
the
#2537
branch
3 times, most recently
from
0448010
to
84245dd
Compare
giacomocusinato
force-pushed
the
#2537
branch
from
84245dd
to
cdb6d9e
Compare
giacomocusinato
changed the title
giacomocusinato
force-pushed
the
#2537
branch
from
cdb6d9e
to
cf78a68
Compare
Resolves #2537 Fix memory leak issue caused by inflight dependency, see isaacs/node-glob#435
giacomocusinato
force-pushed
the
#2537
branch
from
cf78a68
to
18e2ac1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Change description
Update
globversion to fix memory leak issueSee isaacs/node-glob#435
Use
globversion 10 as the highest compatible with IDE node versionOther information
Closes #2537
Reviewer checklist