Avoid signature expired error on index update, if the clock time is not set correctly.
#2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
type: enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2744 +/- ##
==========================================
- Coverage 67.65% 67.57% -0.09%
==========================================
Files 237 237
Lines 22356 22367 +11
==========================================
- Hits 15126 15114 -12
- Misses 6036 6063 +27
+ Partials 1194 1190 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6 tasks
|
Superseded by #2750 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Some users reported spurious "expired signature" errors. After some investigation, we found that all of them had the wrong system date set on their machine, with a date set in the past. Even if the error says that the signature is "expired", it's a signature that is not yet valid (it will be in the future).
Since we cannot trust the system clock, we recheck the signature with a future date so we may avoid displaying a difficult-to-understand error to the user.
This PR will suppress the, apparently unrelated,
signature expirederror in such cases.What is the current behavior?
An index update will trigger a
signature expirederror if the clock is set to a past date.What is the new behavior?
If the clock is set to a past date, an index update will no longer trigger a
signature expirederror.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information