-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pre_uninstall scripts #2311
Add support for pre_uninstall scripts #2311
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2311 +/- ##
==========================================
+ Coverage 63.03% 63.14% +0.11%
==========================================
Files 200 200
Lines 19206 19260 +54
==========================================
+ Hits 12106 12162 +56
+ Misses 6053 6052 -1
+ Partials 1047 1046 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I would only add a test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some code duplication here, this could be an excellent use of subtests
c78ae7a
to
cc4fc16
Compare
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Code enhancement
What is the new behavior?
Support for pre_uninstall scripts has been added. The default behaviour of the CLI can be altered using the flags
--run-pre-uninstall
and--skip-pre-uninstall
.Does this PR introduce a breaking change, and is titled accordingly?