Added Example and Bug fixes on Ethernet #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
per1234
added
type: imperfection
ssilverman
reviewed
Jul 11, 2024
| @@ -28,11 +31,18 @@ GSMConnectionHandler conMan(SECRET_APN, SECRET_PIN, SECRET_GSM_USER, SECRET_GSM_ | |||
| NBConnectionHandler conMan(SECRET_PIN); | |||
| #elif defined(BOARD_HAS_LORA) | |||
| LoRaConnectionHandler conMan(SECRET_APP_EUI, SECRET_APP_KEY); | |||
| #elif defined(BOARD_HAS_ETHERNET) | |||
| byte mac[] = { 0xDE, 0xAD, 0xBE, 0xEF, 0xFE, 0xED }; | |||
There was a problem hiding this comment.
The Teensy 4.0 and 4.1 have a built-in MAC address that should be used instead. Perhaps a board check here is appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case for my research where I am trying to use the ArduinoIOTCloud library on a Teensy 4.0 with an ATECC608A along with a Wiznet Ethernet Module. I was able to get the modified example to work on it and get a "CONNECTED to network" on the serial monitor.