-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for WPA2 Enterprise #65
base: master
Are you sure you want to change the base?
Conversation
jesmith-all
commented
Aug 9, 2021
- Adds optional argument to WifiConnectionHandler constructor to pass a username
- Conditional in .cpp checks if value has been set, calls on .begin or .beginEnterprise accordingly
- Critical to use at universities
- If merged, would allow students on university networks to use IoT Cloud without modifying a local copy of the library
…ditional to substitute Wifi.beginEnterprise method() when modified from default value.
Hi @jesmith-all , |
Fair enough. With an active course now and more around the corner, I sought the path of least resistance in edits that would add the functionality as a stop gap, but you're right that this isn't as clean as it could be. I have not been tracking these other developments, but it's great to hear that you've got a vision for how things could coalesce. I'll take a look and circle back. |
@facchinm Does it still need to be in a derived class? I see that the project file structure has changed quite a bit since this PR, but if it still needs to be a separate class, I can give it a go. |