-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test if it leaks when the given signal never aborts and connection succeeds #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Snapshot Release (
|
Package | Version | Info |
---|---|---|
@whatwg-node/fetch |
0.10.2-alpha-20250107153812-2b7cc1f8c195a23bdaa804e863be3032890ab3c1 |
npm ↗︎ unpkg ↗︎ |
@whatwg-node/node-fetch |
0.7.6-alpha-20250107153812-2b7cc1f8c195a23bdaa804e863be3032890ab3c1 |
npm ↗︎ unpkg ↗︎ |
✅
|
✅
|
✅
|
✅
|
✅
|
dotansimha
approved these changes
Jan 8, 2025
Urigo
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two tests;
AbortSignal
from anAbortController
never aborts, and the fetch call succeeds to see if it leaksAbortSignal.timeout
and it doesn't timeout and fetch call succeeds before it times out. And we check if it leaksAnd it also removes the event listener added in
node-libcurl
based fetch implementation to make sure it doesn't leak.This change doesn't affect Hive Gateway's this issue graphql-hive/gateway#303 (comment) because Hive GW doesn't use node-libcurl directly. Only tests are added to see if the leak is reproduced regardless the change.