Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove node: protocol from imports #1190

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Mar 12, 2024

No description provided.

Copy link

codesandbox bot commented Mar 12, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@whatwg-node/node-fetch 0.5.8-alpha-20240312161556-e6d3e27cadcaaa8338844ba5d1ab398c9828c328 npm ↗︎ unpkg ↗︎
@whatwg-node/server 0.9.28-alpha-20240312161556-e6d3e27cadcaaa8338844ba5d1ab398c9828c328 npm ↗︎ unpkg ↗︎

Copy link
Contributor

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=140.444947 min=12     med=141     max=199      p(90)=161     p(95)=166    
     data_received..................: 24 MB  805 kB/s
     data_sent......................: 16 MB  521 kB/s
     http_req_blocked...............: avg=2.87µs     min=621ns  med=1.42µs  max=7.74ms   p(90)=2.04µs  p(95)=2.26µs 
     http_req_connecting............: avg=1.11µs     min=0s     med=0s      max=7.6ms    p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=18.94ms    min=2.42ms med=18.44ms max=733.43ms p(90)=24.66ms p(95)=26.18ms
       { expected_response:true }...: avg=18.94ms    min=2.42ms med=18.44ms max=733.43ms p(90)=24.66ms p(95)=26.18ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 157872
     http_req_receiving.............: avg=37.22µs    min=8.94µs med=25.96µs max=21.03ms  p(90)=41.08µs p(95)=49.49µs
     http_req_sending...............: avg=11.29µs    min=2.8µs  med=6.27µs  max=18.56ms  p(90)=9.15µs  p(95)=14.1µs 
     http_req_tls_handshaking.......: avg=0s         min=0s     med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=18.89ms    min=2.37ms med=18.4ms  max=733.38ms p(90)=24.61ms p(95)=26.11ms
     http_reqs......................: 157872 5261.290851/s
     iteration_duration.............: avg=37.97ms    min=9.47ms med=36.98ms max=767.74ms p(90)=41.41ms p(95)=47.08ms
     iterations.....................: 78906  2629.645636/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=140.304249 min=58       med=141     max=196      p(90)=158     p(95)=164    
     data_received..................: 22 MB  728 kB/s
     data_sent......................: 14 MB  467 kB/s
     http_req_blocked...............: avg=4.16µs     min=691ns    med=1.35µs  max=16.02ms  p(90)=2.04µs  p(95)=2.25µs 
     http_req_connecting............: avg=2.29µs     min=0s       med=0s      max=6.11ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=20.95ms    min=726.13µs med=20.43ms max=855.36ms p(90)=26.74ms p(95)=29ms   
       { expected_response:true }...: avg=20.95ms    min=726.13µs med=20.43ms max=855.36ms p(90)=26.74ms p(95)=29ms   
     http_req_failed................: 0.00%  ✓ 0           ✗ 142724
     http_req_receiving.............: avg=34.17µs    min=9.25µs   med=25.35µs max=20.07ms  p(90)=40.59µs p(95)=47.74µs
     http_req_sending...............: avg=9.81µs     min=3.04µs   med=5.94µs  max=13.13ms  p(90)=8.91µs  p(95)=12.33µs
     http_req_tls_handshaking.......: avg=0s         min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=20.91ms    min=706.05µs med=20.39ms max=855.29ms p(90)=26.7ms  p(95)=28.96ms
     http_reqs......................: 142724 4756.831821/s
     iteration_duration.............: avg=42ms       min=18.88ms  med=40.71ms max=875.38ms p(90)=46.42ms p(95)=50.62ms
     iterations.....................: 71333  2377.449373/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

@benchmarks/server results

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 301508      ✗ 0     
     data_received..................: 30 MB   990 kB/s
     data_sent......................: 12 MB   402 kB/s
     http_req_blocked...............: avg=1.36µs   min=841ns    med=1.16µs   max=178.28µs p(90)=1.88µs   p(95)=2.04µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=124.99µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=137.62µs min=93.33µs  med=133.23µs max=7.59ms   p(90)=154.81µs p(95)=161.35µs
       { expected_response:true }...: avg=137.62µs min=93.33µs  med=133.23µs max=7.59ms   p(90)=154.81µs p(95)=161.35µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 150754
     http_req_receiving.............: avg=25.28µs  min=12.54µs  med=24.22µs  max=584.81µs p(90)=31.15µs  p(95)=33.04µs 
     http_req_sending...............: avg=5.69µs   min=3.61µs   med=4.99µs   max=157.24µs p(90)=7.43µs   p(95)=7.89µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=106.64µs min=68.4µs   med=101.68µs max=7.52ms   p(90)=120.48µs p(95)=125.79µs
     http_reqs......................: 150754  5025.115922/s
     iteration_duration.............: avg=193.27µs min=137.24µs med=187.28µs max=7.71ms   p(90)=212.43µs p(95)=221.23µs
     iterations.....................: 150754  5025.115922/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@ardatan ardatan merged commit c6f93ee into master Mar 12, 2024
21 checks passed
@ardatan ardatan deleted the remove-node-protocol branch March 12, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant