Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unavailable result status #146

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Conversation

DorianGreen
Copy link

When making calls to downstream services or databases transient errors could occur that may get resolved if the operation is retried.

This PR adds an Unavailable result status and a mapping to a 503 Service Unavailable http result.

Usage scenarios:

  1. A service adds a resiliency layer (using Polly for example) to handle retries.
    instead of handling various exception or error types in the shared resiliency layer, the developer can handle these cases closer to where they occur and return Result.Unavailable. the resiliency layer can now be made generic, and error agnostic, and retry based on the result status.

  2. while making a call to a downstream service, we get some transient error (database unavailable). the service layer can handle the error and return Result.Unavailable and the result will be converted to a 503 http response instead of a default 500 or 422.
    Callers of our API get a better experience and can add their own resiliency layers if needed.

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Ardalis.Result 0% 0% 79
Ardalis.Result.AspNetCore 38% 45% 159
Summary 23% (120 / 515) 40% (59 / 146) 238

@ardalis ardalis merged commit c9adeff into ardalis:main Sep 22, 2023
1 check passed
@ardalis
Copy link
Owner

ardalis commented Sep 22, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants