Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to Astro 5 #370

Merged
merged 3 commits into from
Jan 16, 2025
Merged

chore: Upgrade to Astro 5 #370

merged 3 commits into from
Jan 16, 2025

Conversation

davidmytton
Copy link
Contributor

@davidmytton davidmytton commented Jan 16, 2025

Workarounds for broken things:

Custom formatting of types

I had to comment out:

//let code = await format(types.join("\n"), { parser: "typescript" });

It broke in this upgrade with errors at runtime:

10:24:41 [ERROR] Property or signature expected. (8:5)
  6 |     headers: Headers;
  7 | } | {
> 8 |     ...;
    |     ^
  9 | }
  Hint:
    This issue often occurs when your MDX component encounters runtime errors.
  Stack trace:
    at /workspaces/arcjet-docs/node_modules/prettier/plugins/typescript.mjs:17:70560
    [...] See full stack trace in the browser, or rerun with --verbose.
  Caused by:
  Property or signature expected.
    at ed (file:///workspaces/arcjet-docs/node_modules/prettier/plugins/typescript.mjs:17:8588)
    [...] See full stack trace in the browser, or rerun with --verbose.

Broken search

The Vercel adapter doesn't copy files correctly: withastro/adapters#445. I applied the workaround in withastro/adapters#445 (comment)

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
arcjet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:52am

Copy link

socket-security bot commented Jan 16, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ai-sdk/[email protected] 🔁 npm/@ai-sdk/[email protected] Transitive: environment, network +6 5.49 MB vercel-release-bot
npm/@astrojs/[email protected] 🔁 npm/@astrojs/[email protected] Transitive: environment, eval, filesystem, unsafe +84 245 MB fredkschott
npm/@astrojs/[email protected] 🔁 npm/@astrojs/[email protected] Transitive: environment, filesystem, network, shell +231 28.9 MB fredkschott
npm/@astrojs/[email protected] 🔁 npm/@astrojs/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +136 241 MB matthewp
npm/@clerk/[email protected] 🔁 npm/@clerk/[email protected] Transitive: environment +21 6.54 MB nikosdouvlis
npm/@connectrpc/[email protected] network +2 1.07 MB sayers-buf
npm/@connectrpc/[email protected] network +2 924 kB sayers-buf
npm/@expressive-code/[email protected] 🔁 npm/@expressive-code/[email protected] None +54 2.93 MB hippotastic
npm/@expressive-code/[email protected] 🔁 npm/@expressive-code/[email protected] None +54 2.89 MB hippotastic
npm/@faker-js/[email protected] 🔁 npm/@faker-js/[email protected] None 0 8.54 MB division-by-zero, shinigami92, st-ddt
npm/@fontsource-variable/[email protected] 🔁 npm/@fontsource-variable/[email protected] None 0 80.1 kB lotusdevshack
npm/@fontsource-variable/[email protected] 🔁 npm/@fontsource-variable/[email protected] None 0 135 kB lotusdevshack
npm/@fontsource/[email protected] 🔁 npm/@fontsource/[email protected] None 0 1.48 MB lotusdevshack
npm/@langchain/[email protected] 🔁 npm/@langchain/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +113 65.9 MB jacoblee93
npm/@nanostores/[email protected] 🔁 npm/@nanostores/[email protected] None 0 4.85 kB ai
npm/@nestjs/[email protected] 🔁 npm/@nestjs/[email protected] None +7 4.97 MB
npm/@nestjs/[email protected] 🔁 npm/@nestjs/[email protected] Transitive: filesystem, network, shell +20 5.68 MB
npm/@nestjs/[email protected] 🔁 npm/@nestjs/[email protected] Transitive: environment, eval, filesystem, unsafe +61 2 MB
npm/@remix-run/[email protected] 🔁 npm/@remix-run/[email protected] Transitive: environment, eval, filesystem, network +56 24.2 MB mjackson
npm/@sveltejs/[email protected] 🔁 npm/@sveltejs/[email protected] Transitive: filesystem +75 239 MB svelte-admin
npm/@types/[email protected] 🔁 npm/@types/[email protected] None +3 3.38 MB types
npm/@types/[email protected] 🔁 npm/@types/[email protected] None +1 2.37 MB types
npm/@types/[email protected] 🔁 npm/@types/[email protected] None 0 20.6 kB types
npm/@types/[email protected] 🔁 npm/@types/[email protected] None +1 1.98 MB types
npm/[email protected] 🔁 npm/[email protected] None +17 9.11 MB vercel-release-bot
npm/[email protected] 🔁 npm/[email protected] Transitive: environment, eval, filesystem, network, shell +303 274 MB fredkschott
npm/[email protected] 🔁 npm/[email protected] Transitive: eval, unsafe +68 2.18 MB jonchurch
npm/[email protected] 🔁 npm/[email protected] None 0 1.07 MB yusukebe
npm/[email protected] 🔁 npm/[email protected] None +15 3.99 MB thvu
npm/[email protected] 🔁 npm/[email protected] Transitive: eval +25 1.29 GB rauchg, timneutkens, vercel-release-bot
npm/[email protected] 🔁 npm/[email protected] Transitive: eval, filesystem +12 1.19 MB davidmarkclements, jsumners, matteo.collina, ...1 more
npm/[email protected] 🔁 npm/[email protected] None +1 84.2 kB
npm/[email protected] 🔁 npm/[email protected] None 0 0 B
npm/[email protected] 🔁 npm/[email protected] Transitive: environment, shell +27 13.3 MB hcatlin, nex3, sassbot
npm/[email protected] 🔁 npm/[email protected] None +29 1.92 MB hideoo
npm/[email protected] 🔁 npm/[email protected], npm/[email protected] None 0 410 kB sindresorhus
npm/[email protected] 🔁 npm/[email protected] None 0 22.7 MB typescript-bot
npm/[email protected] 🔁 npm/[email protected] None 0 0 B

View full report↗︎

Copy link

socket-security bot commented Jan 16, 2025

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
New author npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Network access npm/[email protected] 🚫
Unstable ownership npm/[email protected] 🚫
Install scripts npm/@parcel/[email protected]
  • Install script: install
  • Source: node scripts/build-from-source.js
🚫
Native code npm/@parcel/[email protected] 🚫
Shell access npm/@parcel/[email protected] 🚫
New author npm/@vscode/[email protected] 🚫
Unstable ownership npm/@vscode/[email protected] 🚫
Unstable ownership npm/[email protected] 🚫
New author npm/[email protected] 🚫
New author npm/[email protected] 🚫
License Policy Violation npm/@fontsource/[email protected]
  • License: OFL-1.1 - Not allowed by license policy (npm metadata, package/LICENSE, package/package.json)
⚠︎
License Policy Violation npm/@fontsource-variable/[email protected]
  • License: OFL-1.1 - Not allowed by license policy (npm metadata, package/LICENSE, package/package.json)
⚠︎
License Policy Violation npm/@fontsource-variable/[email protected]
  • License: OFL-1.1 - Not allowed by license policy (npm metadata, package/LICENSE, package/package.json)
⚠︎
Shell access npm/[email protected] 🚫
License Policy Violation npm/[email protected]
  • License: CC-BY-SA-4.0 - Not allowed by license policy (package/dist/compiled/glob/LICENSE, package/dist/compiled/glob/LICENSE)
⚠︎
License Policy Violation npm/[email protected]
  • License: CC-BY-4.0 - Not allowed by license policy (package/ThirdPartyNoticeText.txt)
  • License: W3C-20150513 - Not allowed by license policy (package/ThirdPartyNoticeText.txt)
⚠︎
License Policy Violation npm/[email protected]
  • License: CC-BY-4.0 - Not allowed by license policy (npm metadata, package/LICENSE, package/package.json)
⚠︎
Unstable ownership npm/[email protected] 🚫

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the number of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Why is native code a concern?

Contains native code (e.g., compiled binaries or shared libraries). Including native code can obscure malicious behavior.

Verify that the inclusion of native code is expected and necessary for this package's functionality. If it is unnecessary or unexpected, consider using alternative packages without native code to mitigate potential risks.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is a license policy violation?

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@davidmytton davidmytton merged commit 9848cec into main Jan 16, 2025
3 of 4 checks passed
@davidmytton davidmytton deleted the david/astro-5 branch January 16, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant