Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues #1445 #1603

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixing issues #1445 #1603

wants to merge 3 commits into from

Conversation

Mike014
Copy link

@Mike014 Mike014 commented Jan 25, 2025

Hi everyone, my name is Michele and I wanted to contribute to the realization of the project, I forked this one. Read the README.md file, set the development environment. Having analyzed the various issues to start from, I chose #1445

I analyzed the project with the terminal command,

grep -rnw './' -e 'model' --exclude-dir=venv
grep -rnw './' -e 'models' --exclude-dir=venv

Thus finding reference to model.

I modified the following files,

  • applications/Dockerfile

  • applications/vectorstore/base.py

  • setup.sh

Next I tested the app with commands:

./setup.sh

./run-with-docker-compose.sh

The app worked without any problems, I hope this problem has been solved, with this I would really like to participate in the project, it is truly fantastic for me.

Otherwise I hope to be able to receive adequate feedback to best contribute to the project.

Thank you very much for your attention

Michele Grimaldi
Mike014

Copy link

vercel bot commented Jan 25, 2025

@Mike014 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-docsgpt 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 3:46pm

@dartpain
Copy link
Contributor

Perfect, thank you so much, thats exactly what we needed.

My only query is that you remove your name in the comments that were left in the code

and in here
CleanShot 2025-01-25 at 16 51 33@2x
its completely fine if you delete the old code (run command)

Thank you!

@Mike014
Copy link
Author

Mike014 commented Jan 26, 2025

@dartpain Thank you so much for the feedback! I’ve made the changes you requested and also updated the README.md file where it referred to "model" instead of "models".
I’m really happy that you accepted my PR, and I’ll keep contributing to the project, doing my best to improve and help where I can.

@Mike014
Copy link
Author

Mike014 commented Jan 26, 2025

I had noticed a conflict in the README.md file caused by the term change from model to models. Conflict resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Organise models folders
2 participants