Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add support for osx-configs #324

Merged
merged 11 commits into from
Feb 29, 2024
Merged

Feature: Add support for osx-configs #324

merged 11 commits into from
Feb 29, 2024

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Jan 29, 2024 •
edited by jira bot
Loading

Description

Add support for osx-commons-configs

Task ID: OS-926

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@josemarinas josemarinas added client-release Publishes the current version of client subpackage on NPM client-common-release Releases a new version of the client-common package labels Jan 29, 2024
mathewmeconry
mathewmeconry suggested changes Jan 30, 2024
View reviewed changes
modules/client-common/src/context-core.ts Outdated Show resolved Hide resolved
modules/client-common/src/utils.ts Outdated Show resolved Hide resolved
modules/client-common/src/utils.ts Outdated Show resolved Hide resolved
modules/client-common/src/utils.ts Outdated Show resolved Hide resolved
modules/client/src/addresslistVoting/internal/utils.ts Outdated Show resolved Hide resolved
modules/client/src/multisig/internal/client/encoding.ts Outdated Show resolved Hide resolved
modules/client/src/multisig/internal/client/methods.ts Outdated Show resolved Hide resolved
modules/client/src/tokenVoting/internal/client/encoding.ts Outdated Show resolved Hide resolved
modules/client/src/tokenVoting/internal/client/methods.ts Outdated Show resolved Hide resolved
modules/client/src/tokenVoting/internal/utils.ts Outdated Show resolved Hide resolved
heueristik
heueristik reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few minor things.

@josemarinas josemarinas force-pushed the f/OS-926-use-osx-common-configs branch from f2b6704 to 203fe52 Compare February 14, 2024 08:51
Rekard0
Rekard0 previously approved these changes Feb 14, 2024
View reviewed changes
jordaniza
jordaniza previously approved these changes Feb 15, 2024
View reviewed changes
modules/client-common/src/context-core.ts Show resolved Hide resolved
Rekard0
Rekard0 reviewed Feb 19, 2024
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is out of date, please merge with develop

@josemarinas josemarinas dismissed stale reviews from jordaniza and Rekard0 via 8542c3f February 28, 2024 10:14
@josemarinas josemarinas force-pushed the f/OS-926-use-osx-common-configs branch from 203fe52 to 8542c3f Compare February 28, 2024 10:14
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
14.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@josemarinas josemarinas merged commit e53f221 into develop Feb 29, 2024
7 of 8 checks passed
@josemarinas josemarinas deleted the f/OS-926-use-osx-common-configs branch February 29, 2024 10:36
banasa44 pushed a commit that referenced this pull request Feb 29, 2024
@josemarinas @banasa44
Feature: Add support for osx-configs (#324)
e64f8da 
* add support for osx-configs

* update for new configs

* fix comments and update yarn lock

* fix comments

* fix tests

* fix sonar

* fix sonar

* refactor getNetwork function

* fix comments

* fix: throw error when repo contract is not available

* fix: build
banasa44 added a commit that referenced this pull request Mar 1, 2024
@banasa44 @Rekard0 @josemarinas
Fix/broken anchors docs (#328)
e132db3 
* ci: brokenAnchors for linked typed list fixed

* ci: Add and moddify helpers, functions and handlebars

* ci: manual fixes in .md and .ts files

* Apply suggestions from code review

Co-authored-by: Rekard0 <[email protected]>

* ci: requested changes from code review

* Feature: Add support for osx-configs (#324)

* add support for osx-configs

* update for new configs

* fix comments and update yarn lock

* fix comments

* fix tests

* fix sonar

* fix sonar

* refactor getNetwork function

* fix comments

* fix: throw error when repo contract is not available

* fix: build

---------

Co-authored-by: Rekard0 <[email protected]>
Co-authored-by: josemarinas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathewmeconry mathewmeconry mathewmeconry requested changes

@heueristik heueristik heueristik approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

@jordaniza jordaniza jordaniza left review comments

Assignees
No one assigned
Labels
client-common-release Releases a new version of the client-common package client-release Publishes the current version of client subpackage on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@josemarinas @mathewmeconry @Rekard0 @heueristik @jordaniza